Attachment 14770 Details for Bug 9444 – Bug 9444 - Use DataTables in system preferences editor

[patch] Bug 9444 - Use DataTables in system preferences editor

Bug-9444---Use-DataTables-in-system-preferences-ed.patch (text/plain), 2.66 KB, created by Jonathan Druart on 2013-01-23 08:37:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-01-23 08:37:34 UTC

Size: 2.66 KB

patch

obsolete

>From a274daae6fe408325277c14dd37f0b66331dbfac Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 22 Jan 2013 12:17:55 -0500
>Subject: [PATCH] Bug 9444 - Use DataTables in system preferences editor
>
>Replace the tablesorter plugin with the DataTables plugin in the
>"new" system preferences editor.
>
>To test, open the system preferences editor on any tab other than Local
>Use. Confirm that table sorting works correctly within each section. In
>this configuration there should be no pager and no results filtering.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js     |   11 +++++++----
> .../intranet-tmpl/prog/en/modules/admin/preferences.tt      |    5 ++++-
> 2 files changed, 11 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>index 4d793a1..57f8dd3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>@@ -1,8 +1,11 @@
> $(document).ready(function() {
>-    $("table.preferences").tablesorter({
>-        sortList: [[0,0]],
>-        headers: { 1: { sorter:false}}
>-    });
>+    $("table.preferences").dataTable($.extend(true, {}, dataTablesDefaults, {
>+        "sDom": 't',
>+        "aoColumnDefs": [
>+            { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }
>+        ],
>+        "bPaginate": false
>+    }));
> });
> 
> // We can assume 'KOHA' exists, as we depend on KOHA.AJAX
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>index 139c35e..58c1098 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>@@ -1,7 +1,10 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Administration &rsaquo; System preferences</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script>
>+<link rel="stylesheet" type="text/css" href="/intranet-tmpl/prog/en/css/datatables.css" />
>+<script type="text/javascript" src="/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js"></script>
>+[% INCLUDE 'datatables-strings.inc' %]
>+<script type="text/javascript" src="/intranet-tmpl/prog/en/js/datatables.js"></script>
> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/preferences.css" />
> <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.fixFloat.js"></script>
> <script type="text/javascript">
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9444: 14754 | 14770 | 15699 | 15743 | 15811 | 15817 | 15841