Attachment 147726 Details for Bug 32678 – Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl

[patch] Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl

Bug-32678-Add-new-line-in-authorized-values-tests-.patch (text/plain), 2.07 KB, created by Nick Clemens (kidclamp) on 2023-03-03 19:11:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-03-03 19:11:54 UTC

Size: 2.07 KB

patch

obsolete

>From 5f5214fd8e32d1881275672e7342cc19d2eb285e Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 18 Jan 2023 21:12:48 -1000
>Subject: [PATCH] Bug 32678: Add new line in authorized values tests in
> search_for_data_inconsistencies.pl
>
>In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line :
>	* The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }):
> {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV}
>
>It would be more clear with new lines, especially for scripts (grep, awk ...) :
>	* The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }):
> {94 => AV}
> {95 => AV}
> {96 => AV}
> {97 => AV}
> {98 => AV}
> {99 => AV}
> {100 => AV}
> {101 => AV}
> {102 => AV}
> {103 => AV}
>
>Test plan :
>1) In koha-testing-docker
>2) Delete in authorized values LOC the value AV
>3) Run misc/maintenance/search_for_data_inconsistencies.pl
>=> You see the new line in result
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> misc/maintenance/search_for_data_inconsistencies.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
>index be5923cb3b..7e1befef92 100755
>--- a/misc/maintenance/search_for_data_inconsistencies.pl
>+++ b/misc/maintenance/search_for_data_inconsistencies.pl
>@@ -248,7 +248,7 @@ use C4::Biblio qw( GetMarcFromKohaField );
>                         : $table eq 'biblio'
>                         ? $i->biblio->$column
>                         : $i->biblioitem->$column;
>-                    $output .= " {" . $i->itemnumber . " => " . $value . "}";
>+                    $output .= " {" . $i->itemnumber . " => " . $value . "}\n";
>                 }
>                 new_item(
>                     sprintf(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32678: 145455 | 145706 | 147726