Attachment 147741 Details for Bug 3831 – Bug 3831: Add a warning to about page when there is no FA framework

[patch] Bug 3831: Add a warning to about page when there is no FA framework

Bug-3831-Add-a-warning-to-about-page-when-there-is.patch (text/plain), 4.68 KB, created by Nick Clemens (kidclamp) on 2023-03-03 20:44:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-03-03 20:44:50 UTC

Size: 4.68 KB

patch

obsolete

>From d58a4abd1056e1fa8e6a8cda9145ca940584d510 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 3 Mar 2023 20:41:21 +0000
>Subject: [PATCH] Bug 3831: Add a warning to about page when there is no FA
> framework
>
>The feature is effectively disab;ed throughout Koha when this framework
>is deleted. There do not appear to be any other side effects.
>
>We should report this on the about page for informatinal purposes
>
>To test:
>1 - Apply patch
>2 - Check about page, no change
>3 - sudo koha-mysql kohadev
>    UPDATE biblio_framework SET frameworkcode = 'FB' WHERE
>    frameworkcode = 'FA'
>4 - Refresh about page
>5 - Note new warning
>6 - sudo koha-mysql kohadev
>    UPDATE biblio_framework SET frameworkcode = 'FA' WHERE
>    frameworkcode = 'FB'
>7 - Refresh about page
>8 - No warning
>---
> about.pl                                         | 3 +++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 +++++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/about.pl b/about.pl
>index f4d1c7a959..1296996041 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -588,7 +588,9 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs;
>     my @frameworkcodes = Koha::BiblioFrameworks->search->get_column('frameworkcode');
>     my @hidden_biblionumbers;
>     push @frameworkcodes, ""; # it's not in the biblio_frameworks table!
>+    my $no_FA_framework = 1;
>     for my $frameworkcode ( @frameworkcodes ) {
>+        $no_FA_framework = 0 if $frameworkcode eq 'FA';
>         my $shouldhidemarc_opac = Koha::Filter::MARC::ViewPolicy->should_hide_marc(
>             {
>                 frameworkcode => $frameworkcode,
>@@ -608,6 +610,7 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs;
>           if $shouldhidemarc_intranet->{biblionumber};
>     }
>     $template->param( warnHiddenBiblionumbers => \@hidden_biblionumbers );
>+    $template->param( warnFastCataloging => $no_FA_framework );
> }
> 
> {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index bfde0eca10..fb9e4616a0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -382,10 +382,16 @@
>                                 Contact your system administrator.
>                             [% END # /IF warnConnectBroker %]
> 
>-                            [% IF warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size %]
>+                            [% IF warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnFastCataloging %]
>                                 <h2>Warnings regarding the system configuration</h2>
>                                 <table>
>                                     <caption>Preferences and parameters</caption>
>+                                    [% IF (warnFastCataloging) %]
>+                                        <tr>
>+                                            <th scope="row"><strong>Warning</strong> </th>
>+                                            <td>There is no "Fast add" (FA) framework defined in Administration->MARC frameworks. This disables the 'Fast cataloging' feature in cataloging/circulation.</td>
>+                                        </tr>
>+                                    [% END %]
>                                     [% IF (warnPrefRequireChoosingExistingAuthority) %]
>                                         <tr>
>                                             <th scope="row"><strong>Warning</strong> </th>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 3831: 37209 | 37252 | 37326 | 147741 | 147744 | 148024