Bugzilla – Attachment 147784 Details for
Bug 32558
Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32558: (QA follow-up) Leave default to 1, remove extra fork
Bug-32558-QA-follow-up-Leave-default-to-1-remove-e.patch (text/plain), 1.13 KB, created by
Kyle M Hall
on 2023-03-06 13:26:49 UTC
(
hide
)
Description:
Bug 32558: (QA follow-up) Leave default to 1, remove extra fork
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2023-03-06 13:26:49 UTC
Size:
1.13 KB
patch
obsolete
>From 53ea830181223f3e0fbc49ca87063c2539ca37a9 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 17 Feb 2023 07:25:08 +0000 >Subject: [PATCH] Bug 32558: (QA follow-up) Leave default to 1, remove extra > fork > >The default of 1 resembles the old behavior: 1 fork for the job. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > misc/workers/background_jobs_worker.pl | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > >diff --git a/misc/workers/background_jobs_worker.pl b/misc/workers/background_jobs_worker.pl >index c5b84adcb1..c54610458f 100755 >--- a/misc/workers/background_jobs_worker.pl >+++ b/misc/workers/background_jobs_worker.pl >@@ -160,23 +160,13 @@ while (1) { > } > } > $conn->disconnect; >+$pm->wait_all_children; > > sub process_job { > my ( $job, $args ) = @_; >- >- my $pid; >- if ( $pid = fork ) { >- wait; >- return; >- } >- >- die "fork failed!" unless defined $pid; >- > try { > $job->process( $args ); > } catch { > $job->status('failed')->store; > }; >- >- exit; > } >-- >2.39.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32558
:
144946
|
144947
|
144960
|
144961
|
145043
|
145062
|
145067
|
145900
|
145901
|
145950
|
146020
|
146753
|
146754
| 147784 |
147828