Bugzilla – Attachment 147804 Details for
Bug 8367
How long is a hold waiting for pickup at a more granular level
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8367: (follow-up) Remove unnecessary code and atomic update
Bug-8367-follow-up-Remove-unnecessary-code-and-ato.patch (text/plain), 2.54 KB, created by
Nick Clemens (kidclamp)
on 2023-03-06 20:06:48 UTC
(
hide
)
Description:
Bug 8367: (follow-up) Remove unnecessary code and atomic update
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-03-06 20:06:48 UTC
Size:
2.54 KB
patch
obsolete
>From 8b8ac16745335055137ca00679d9fe456b7a89a6 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 2 Nov 2022 08:48:19 +1300 >Subject: [PATCH] Bug 8367: (follow-up) Remove unnecessary code and atomic > update > >Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../bug_8367-add_holds_pickup_period_circrule.perl | 10 ---------- > .../cronjobs/thirdparty/TalkingTech_itiva_outbound.pl | 11 ----------- > 2 files changed, 21 deletions(-) > delete mode 100644 installer/data/mysql/atomicupdate/bug_8367-add_holds_pickup_period_circrule.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_8367-add_holds_pickup_period_circrule.perl b/installer/data/mysql/atomicupdate/bug_8367-add_holds_pickup_period_circrule.perl >deleted file mode 100644 >index d7cbe86eee..0000000000 >--- a/installer/data/mysql/atomicupdate/bug_8367-add_holds_pickup_period_circrule.perl >+++ /dev/null >@@ -1,10 +0,0 @@ >-$DBversion = 'XXX'; >-if( CheckVersion( $DBversion ) ) { >- $dbh->do(q{ >- INSERT INTO circulation_rules (branchcode, categorycode, itemtype, rule_name, rule_value) >- SELECT u.* FROM (SELECT NULL as branchcode, NULL as categorycode, NULL as itemtype, 'holds_pickup_period' as rule_name, '' as rule_value) u >- WHERE NOT EXISTS ( SELECT rule_name FROM circulation_rules where rule_name = 'holds_pickup_period' ); >- }); >- >- NewVersion( $DBversion, 8367, "Add holds_pickup_period circulation rule" ); >-} >diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >index 2b54af94b1..5f679a9932 100755 >--- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >+++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >@@ -339,17 +339,6 @@ sub GetWaitingHolds { > > my $waiting_date = dt_from_string( $issue->{waitingdate}, 'sql' ); > >- my $rule = Koha::CirculationRules->get_effective_rule({ >- categorycode => $issue->{categorycode}, >- itemtype => $item->effective_itemtype, >- branchcode => $issue->{branchcode}, >- rule_name => 'holds_pickup_period', >- }); >- if ( defined($rule) and $rule->rule_value ne '' ){ >- # circulation rule overrides ReservesMaxPickUpDelay >- $pickupdelay = $rule->rule_value; >- } >- > $issue->{'date_due'} = output_pref({dt => dt_from_string($issue->{expirationdate}), dateformat => 'iso' }); > $issue->{'level'} = 1; # only one level for Hold Waiting notifications > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8367
:
12130
|
13139
|
13602
|
13603
|
13604
|
13624
|
15334
|
15335
|
15369
|
15498
|
15613
|
15658
|
15659
|
19093
|
19094
|
19095
|
19096
|
19104
|
19105
|
19107
|
19108
|
19116
|
19180
|
19181
|
19182
|
19360
|
19361
|
19362
|
20300
|
20301
|
20302
|
20303
|
20304
|
32786
|
32826
|
32884
|
32885
|
32916
|
32930
|
42706
|
42754
|
79790
|
79791
|
79798
|
79799
|
79800
|
79853
|
79854
|
79855
|
79859
|
92412
|
92413
|
92414
|
92415
|
92416
|
92417
|
92418
|
92419
|
92420
|
92421
|
92422
|
92423
|
92424
|
92425
|
92426
|
92427
|
92428
|
92958
|
92959
|
92960
|
92961
|
103425
|
113211
|
117284
|
118017
|
118021
|
124568
|
125087
|
131299
|
131300
|
131301
|
131302
|
131646
|
131647
|
131718
|
131719
|
131720
|
131722
|
131723
|
131724
|
133089
|
133090
|
133091
|
133092
|
133093
|
133094
|
142897
|
142898
|
142899
|
142900
|
142901
|
142902
|
142903
|
144097
|
144098
|
144099
|
144100
|
144101
|
144102
|
144103
|
144146
|
145644
|
145657
|
147798
|
147799
|
147800
|
147801
|
147802
|
147803
|
147804
|
147805
|
147806
|
147807
|
148536
|
148537
|
148538
|
148539
|
148540
|
148541
|
148542
|
148543
|
148544
|
148545
|
150437
|
150438
|
150439
|
153235
|
153237
|
153238
|
153239
|
153240
|
153241
|
153242
|
153243
|
153244
|
153245
|
153246
|
157138
|
157139
|
157140
|
157141
|
157142
|
157143
|
157144
|
157145
|
157146
|
157147
|
157148
|
157149
|
157150
|
157298
|
157343
|
157344
|
157345
|
157346
|
157347
|
157348
|
157349
|
157350
|
157351
|
157352
|
157354
|
157355
|
157356
|
157697
|
157698
|
157699
|
157700
|
157701
|
157702
|
157703
|
157704
|
157705
|
157706
|
157707
|
157708
|
157709
|
157715
|
158023
|
158024
|
158025
|
158026
|
158027
|
158028
|
158029
|
158030
|
158031
|
158032
|
158033
|
158034
|
158035
|
158254
|
158255