Bugzilla – Attachment 147890 Details for
Bug 33164
Return claim message shows intermittently when BlockReturnOfLostItems enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33164: Ensure return claim message shows if lost item return blocked
Bug-33164-Ensure-return-claim-message-shows-if-los.patch (text/plain), 1.49 KB, created by
Aleisha Amohia
on 2023-03-08 03:57:19 UTC
(
hide
)
Description:
Bug 33164: Ensure return claim message shows if lost item return blocked
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2023-03-08 03:57:19 UTC
Size:
1.49 KB
patch
obsolete
>From d31764f28b1d74132dbca043f365035a41acbcc5 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 8 Mar 2023 11:07:04 +1300 >Subject: [PATCH] Bug 33164: Ensure return claim message shows if lost item > return blocked > >This fix ensures that a return claim confirmation always shows, even if >the return of lost items has been blocked by BlockReturnOfLostItems >being enabled. > >To test: > >1. Set BlockReturnOfLostItems system preference to Block >2. Check out an item to a patron >3. Go to the patrons page and claim a return on the item >4. Check in the item and keep checking in the item. Notice the message >"Item is lost, cannot be checked in." shows every time, but the return >claim message only shows sometimes. > >5. Apply the patch and restart services > >6. Check in the item and keep checking in the item. Confirm both the >lost message shows and the return claim message shows every time. >7. Confirm the return of the item is still blocked. > >Sponsored-by: Pymble Ladies' College >--- > circ/returns.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 2c2bea8aa80..1f6df7522d1 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -663,7 +663,6 @@ foreach my $code ( keys %$messages ) { > } > elsif ( $code eq 'WasLost' ) { > $err{waslost} = 1; >- $exit_required_p = 1 if C4::Context->preference("BlockReturnOfLostItems"); > } > elsif ( $code eq 'LostItemFeeRefunded' ) { > $template->param( LostItemFeeRefunded => 1 ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33164
:
147890
|
157710
|
157993
|
157994
|
158760
|
158761