Bugzilla – Attachment 147939 Details for
Bug 32991
Improve our Dialog component and remove routes for deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID
Bug-32991-Style-the-dialog-to-be-in-line-with-rest.patch (text/plain), 2.98 KB, created by
Agustín Moyano
on 2023-03-08 14:39:40 UTC
(
hide
)
Description:
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID
Filename:
MIME Type:
Creator:
Agustín Moyano
Created:
2023-03-08 14:39:40 UTC
Size:
2.98 KB
patch
obsolete
>From 3e077e3929083f9b827741675d350d71d0334693 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 24 Feb 2023 11:32:29 +0000 >Subject: [PATCH] Bug 32991: Style the dialog to be in line with rest of Koha; > Fix duplicate HTML element ID >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Signed-off-by: AgustÃn Moyano <agustinmoyano@theke.io> >--- > .../prog/js/vue/components/Dialog.vue | 39 ++++++++----------- > 1 file changed, 16 insertions(+), 23 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >index 6662075a0c..85ce4bd2e7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >@@ -2,33 +2,28 @@ > <div class="dialog message" v-if="message" v-html="message"></div> > <div class="dialog alert" v-if="error" v-html="error"></div> > <div class="dialog alert modal" v-if="warning"> >- <span v-html="warning"></span> >- <a >- id="close_modal" >- class="btn btn-default btn-xs" >- role="button" >- @click="removeMessages" >- >{{ $__("Close") }}</a >- > >+ <h1 v-html="warning"></h1> >+ <button id="close_modal" class="approve" @click="removeMessages"> >+ <i class="fa fa-fw fa-check"></i> >+ {{ $__("Close") }} >+ </button> > </div> > <div class="modal_centered" v-if="confirmation"> > <div class="dialog alert confirmation"> >- <span v-html="confirmation"></span> >- <a >+ <h1 v-html="confirmation"></h1> >+ <button > v-if="accept" >- id="close_modal" >- class="btn btn-primary btn-xs" >- role="button" >+ id="accept_modal" >+ class="approve" > @click="accept" >- >{{ $__("Accept") }}</a >- > >- <a >- id="close_modal" >- class="btn btn-default btn-xs" >- role="button" >- @click="removeMessages" >- >{{ $__("Close") }}</a > > >+ <i class="fa fa-fw fa-check"></i> >+ {{ $__("Accept") }} >+ </button> >+ <button id="close_modal" class="deny" @click="removeMessages"> >+ <i class="fa fa-fw fa-remove"></i> >+ {{ $__("Close") }} >+ </button> > </div> > </div> > <!-- Must be styled differently --> >@@ -83,7 +78,6 @@ export default { > transition: all 0.3s ease; > } > #close_modal { >- float: right; > cursor: pointer; > } > >@@ -110,7 +104,6 @@ export default { > top: 25%; > left: 40%; > >- display: flex; > width: 50%; > min-height: 10%; > margin: auto; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32991
:
146828
|
146829
|
147051
|
147052
|
147053
|
147054
|
147082
|
147083
|
147281
|
147282
|
147291
|
147305
|
147350
|
147383
|
147384
|
147385
|
147387
|
147388
|
147389
|
147390
|
147391
|
147392
|
147393
|
147394
|
147429
|
147439
|
147445
|
147447
|
147448
|
147449
|
147450
|
147451
|
147452
|
147453
|
147454
|
147455
|
147456
|
147461
|
147483
|
147485
|
147486
|
147487
|
147542
|
147543
|
147544
|
147545
|
147546
|
147547
|
147548
|
147549
|
147550
|
147551
|
147552
|
147553
|
147554
|
147569
|
147573
|
147584
|
147588
|
147589
|
147590
|
147591
|
147592
|
147593
|
147594
|
147595
|
147596
|
147597
|
147598
|
147599
|
147600
|
147601
|
147602
|
147603
|
147604
|
147937
|
147938
| 147939 |
147940
|
147941
|
147942
|
147943
|
147944
|
147945
|
147946
|
147947
|
147948
|
147949
|
147950
|
147951