Attachment 147958 Details for Bug 33152 – Bug 33152: Add focus to search field

[patch] Bug 33152: Add focus to search field

Bug-33152-Add-focus-to-search-field.patch (text/plain), 1.53 KB, created by Lucas Gass (lukeg) on 2023-03-08 14:48:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-03-08 14:48:51 UTC

Size: 1.53 KB

patch

obsolete

>From 365ab57749e3679dcd0232f3961f2fc1cbf71376 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 8 Mar 2023 12:04:57 +0000
>Subject: [PATCH] Bug 33152: Add focus to search field
>
>This patch adds focus to the search field for a new SQL report from
>mana.
>
>Test plan:
>1) Navigate to Reports > Create from SQL
>2) Click on the new report dropdown and select "New SQL from Mana"
>3) Observe that there is no focus on the input and the user needs to
>   click to start typing
>4) Apply patch
>5) Repeat steps 1-2
>6) There should now be focus on the input and typing can be started
>   immediately
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt           | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 0733fca6f4..be37f1e474 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -2187,6 +2187,10 @@
>                 mana_use( $(this).data("report_id") );
>             });
> 
>+            $("#mana_search_result").on("shown.bs.modal", function(){
>+                $("#mana_search_field").focus();
>+            });
>+
>             $("#mana_search_result").on("hide.bs.modal", function(){
>                 $("#mana_result_content").html("");
>                 $("#mana_search_field").val("");
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33152: 147901 | 147958 | 148036