Bugzilla – Attachment 148030 Details for
Bug 33100
Authority linking doesn't work for bib headings ending in two or more punctuation characters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33100: Unit test
Bug-33100-Unit-test.patch (text/plain), 2.58 KB, created by
Nick Clemens (kidclamp)
on 2023-03-09 20:42:18 UTC
(
hide
)
Description:
Bug 33100: Unit test
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-03-09 20:42:18 UTC
Size:
2.58 KB
patch
obsolete
>From cce8ab7786c040a5af6e973a26ce4537c2734bc6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 7 Mar 2023 20:05:28 +0000 >Subject: [PATCH] Bug 33100: Unit test > >--- > t/db_dependent/Heading.t | 38 ++++++++++++++++++++++++++++++++++++-- > 1 file changed, 36 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Heading.t b/t/db_dependent/Heading.t >index bef0162d2e..20f94ac3b3 100755 >--- a/t/db_dependent/Heading.t >+++ b/t/db_dependent/Heading.t >@@ -18,7 +18,7 @@ > use strict; > use warnings; > >-use Test::More tests => 3; >+use Test::More tests => 4; > > use t::lib::Mocks; > >@@ -60,4 +60,38 @@ subtest "UNIMARC tests" => sub { > ok(!C4::Heading::valid_heading_subfield('600', 'i'), '600i not valid for bib'); > > ok(!C4::Heading::valid_heading_subfield('012', 'a'), '012a invalid field for bib'); >-} >+}; >+ >+subtest "_search tests" => sub { >+ plan tests => 3; >+ >+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); >+ t::lib::Mocks::mock_preference('SearchEngine', 'Elasticsearch'); >+ my $search = Test::MockModule->new('Koha::SearchEngine::Elasticsearch::Search'); >+ >+ $search->mock('search_auth_compat', sub { >+ my $self = shift; >+ my $search_query = shift; >+ return $search_query; >+ }); >+ >+ my $field = MARC::Field->new( '100', ' ', '', a => 'Yankovic, Al', d => '1959-,' ); >+ my $heading = C4::Heading->new_from_field($field); >+ my $search_query = $heading->_search( 'match-heading' ); >+ my $terms = $search_query->{query}->{bool}->{must}; >+ is_deeply( $terms->[0], { term => { 'match-heading.ci_raw' => 'Yankovic, Al 1959' } }, "Search formed as expected for a non-subject field with single punctuation mark"); >+ >+ >+ my $field = MARC::Field->new( '100', ' ', '', a => 'Yankovic, Al', d => '1959-,', e => '[author]' ); >+ my $heading = C4::Heading->new_from_field($field); >+ my $search_query = $heading->_search( 'match-heading' ); >+ my $terms = $search_query->{query}->{bool}->{must}; >+ is_deeply( $terms->[0], { term => { 'match-heading.ci_raw' => 'Yankovic, Al 1959' } }, "Search formed as expected for a non-subject field with doulbe punctuation, hyphen+comma"); >+ >+ $field = MARC::Field->new( '100', ' ', '', a => 'Tolkien, J.R.R.,', e => '[author]' ); >+ $heading = C4::Heading->new_from_field($field); >+ $search_query = $heading->_search( 'match-heading' ); >+ $terms = $search_query->{query}->{bool}->{must}; >+ is_deeply( $terms->[0], { term => { 'match-heading.ci_raw' => 'Tolkien, J.R.R' } }, "Search formed as expected for a non-subject field with double punctuation, period+comma "); >+ >+}; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33100
:
147885
|
147886
|
148030
|
148031
|
148225
|
148226
|
148337