Bugzilla – Attachment 148031 Details for
Bug 33100
Authority linking doesn't work for bib headings ending in two or more punctuation characters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33100: Remove all punctuation at end of record
Bug-33100-Remove-all-punctuation-at-end-of-record.patch (text/plain), 1.27 KB, created by
Nick Clemens (kidclamp)
on 2023-03-09 20:42:20 UTC
(
hide
)
Description:
Bug 33100: Remove all punctuation at end of record
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-03-09 20:42:20 UTC
Size:
1.27 KB
patch
obsolete
>From 455ec8a049f58edaaf092cd4b7e711d9963d0a4f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 7 Mar 2023 20:05:36 +0000 >Subject: [PATCH] Bug 33100: Remove all punctuation at end of record > >This could potentially be overkill - if you have two records that only >differ in ending punctuation, you might get a false result - I don't >know how likely that is ( as I have mentioned before '!!!' is a band ) > >This seems a reasonable fix > >To test: >1 - Set sysprefs as in bug 33159 >2 - Edit a record, biblionumebr 3 is fine >3 - Add a comma to end of author subfield a >4 - Save and note relinked >5 - Apply patch, restart all >6 - Save again >7 - Linked to original record >--- > C4/Heading/MARC21.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Heading/MARC21.pm b/C4/Heading/MARC21.pm >index 9ae5827541..87d825bb4c 100644 >--- a/C4/Heading/MARC21.pm >+++ b/C4/Heading/MARC21.pm >@@ -404,7 +404,7 @@ sub _get_search_heading { > my $code = $subfields[$i]->[0]; > my $code_re = quotemeta $code; > my $value = $subfields[$i]->[1]; >- $value =~ s/[\s]*[-,.:=;!%\/][\s]*$//; >+ $value =~ s/[\s]*[-,.:=;!%\/]*[\s]*$//; > next unless $subfields =~ qr/$code_re/; > if ($first) { > $first = 0; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33100
:
147885
|
147886
|
148030
|
148031
|
148225
|
148226
|
148337