Attachment 148037 Details for Bug 33150 – Bug 33150: Add specific message for informing about too_soon for renewal.

[patch] Bug 33150: Add specific message for informing about too_soon for renewal.

Bug-33150-Add-specific-message-for-informing-about.patch (text/plain), 2.30 KB, created by Katrin Fischer on 2023-03-09 22:05:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-03-09 22:05:33 UTC

Size: 2.30 KB

patch

obsolete

>From 80b2e1d068734459fe294877d0d9a6c9b93f077f Mon Sep 17 00:00:00 2001
>From: Andreas Jonsson <andreas.jonsson@kreablo.se>
>Date: Mon, 6 Mar 2023 16:42:05 +0100
>Subject: [PATCH] Bug 33150: Add specific message for informing about too_soon
> for renewal.
>
>The message "No renewals allowed" is incorrect when it is too soon for renewal,
>this patch adds a specific error message.
>
>To test:
>- Make sure the system preference SCOAllowCheckin is set to "allow"
>- Go to Koha administration -> Circulation and fine rules
>- Edit the rule for all items and change "No renewal before" to 1 and save.
>- Check out an item to a borrower (for instance barcode 39999000000719 to the user koha with cardnumber 42).
>- Go to self checkout (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl)
>- Log in as the user (koha/koha)
>- Verify that the error message in the Renew column is "This item cannot yet be renewed."
>
>Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>index 6afd709a78..a157e86cc6 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>@@ -362,6 +362,8 @@
> This is a on-site checkout, it cannot be renewed.
> [% ELSIF ISSUE.renew_error == 'too_unseen' %]
> You have renewed this item the maximum number of consecutive times without it being seen by the library.
>+ [% ELSIF ISSUE.renew_error == 'too_soon' %]
>+ This item cannot yet be renewed.
> [% ELSE %]
> No renewals allowed
> [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33150: 147792 | 148037