Bugzilla – Attachment 148075 Details for
Bug 33161
Implement +strings for GET /items and GET /items/:item_id
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33161: (QA follow-up) Fix api_strings_mapping inconsistency
Bug-33161-QA-follow-up-Fix-apistringsmapping-incon.patch (text/plain), 2.14 KB, created by
Tomás Cohen Arazi
on 2023-03-10 14:33:21 UTC
(
hide
)
Description:
Bug 33161: (QA follow-up) Fix api_strings_mapping inconsistency
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2023-03-10 14:33:21 UTC
Size:
2.14 KB
patch
obsolete
>From e9979d9087d366d85ff6d67d27d5ec789f3f38d0 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 10 Mar 2023 11:33:02 -0300 >Subject: [PATCH] Bug 33161: (QA follow-up) Fix api_strings_mapping > inconsistency > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/Object.t | 6 +++--- > t/db_dependent/Koha/REST/Plugin/Objects.t | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index 38a6eaf0e46..a49a3784c2b 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -311,10 +311,10 @@ subtest "to_api() tests" => sub { > } > }; > >- # mock Koha::Item so it implements 'api_strings_mapping' >+ # mock Koha::Item so it implements 'strings_map' > my $item_mock = Test::MockModule->new('Koha::Item'); > $item_mock->mock( >- 'api_strings_mapping', >+ 'strings_map', > sub { > return $_strings; > } >@@ -475,7 +475,7 @@ subtest "to_api() tests" => sub { > > my $city_mock = Test::MockModule->new('Koha::City'); > $city_mock->mock( >- 'api_strings_mapping', >+ 'strings_map', > sub { > my ( $self, $params ) = @_; > >diff --git a/t/db_dependent/Koha/REST/Plugin/Objects.t b/t/db_dependent/Koha/REST/Plugin/Objects.t >index 3a4832f2f57..99626ac552f 100755 >--- a/t/db_dependent/Koha/REST/Plugin/Objects.t >+++ b/t/db_dependent/Koha/REST/Plugin/Objects.t >@@ -673,7 +673,7 @@ subtest 'objects.find helper with expanded authorised values' => sub { > > my $city_class = Test::MockModule->new('Koha::City'); > $city_class->mock( >- 'api_strings_mapping', >+ 'strings_map', > sub { > my ($self, $params) = @_; > use Koha::AuthorisedValues; >@@ -786,7 +786,7 @@ subtest 'objects.search helper with expanded authorised values' => sub { > > my $city_class = Test::MockModule->new('Koha::City'); > $city_class->mock( >- 'api_strings_mapping', >+ 'strings_map', > sub { > my ($self, $params) = @_; > use Koha::AuthorisedValues; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33161
:
147888
|
147973
|
147977
|
147995
|
147998
|
147999
|
148010
|
148011
|
148012
|
148013
|
148014
|
148039
|
148040
|
148041
|
148042
|
148043
|
148059
|
148060
|
148061
|
148062
|
148063
|
148068
| 148075