Bugzilla – Attachment 148093 Details for
Bug 30920
Add caching to C4::Biblio::GetAuthorisedValueDesc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30920: (follow-up) Cleanup warning from C4::Biblio::GetAuthorisedValueDesc
Bug-30920-follow-up-Cleanup-warning-from-C4BiblioG.patch (text/plain), 898 bytes, created by
Martin Renvoize (ashimema)
on 2023-03-10 16:38:20 UTC
(
hide
)
Description:
Bug 30920: (follow-up) Cleanup warning from C4::Biblio::GetAuthorisedValueDesc
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-03-10 16:38:20 UTC
Size:
898 bytes
patch
obsolete
>From 64ba7096b33d193f5c85aef903f2ffa41928fd2c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 10 Mar 2023 16:33:44 +0000 >Subject: [PATCH] Bug 30920: (follow-up) Cleanup warning from > C4::Biblio::GetAuthorisedValueDesc > >We simply return early and empty if $value is not passed > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Biblio.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index bcfae623bc..1af5e12696 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1375,6 +1375,8 @@ descriptions rather than normal ones when they exist. > sub GetAuthorisedValueDesc { > my ( $tag, $subfield, $value, $framework, $tagslib, $category, $opac ) = @_; > >+ return q{} unless defined($value); >+ > my $cache = Koha::Caches->get_instance(); > my $cache_key; > if ( !$category ) { >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30920
:
135771
|
136292
|
136293
|
144817
|
144818
|
144819
|
148064
|
148065
|
148066
|
148067
|
148087
|
148088
|
148089
|
148090
|
148091
|
148092
| 148093 |
148094