Bugzilla – Attachment 148094 Details for
Bug 30920
Add caching to C4::Biblio::GetAuthorisedValueDesc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30920: (follow-up) Manually flush caches in tests
Bug-30920-follow-up-Manually-flush-caches-in-tests.patch (text/plain), 2.89 KB, created by
Martin Renvoize
on 2023-03-10 16:38:23 UTC
(
hide
)
Description:
Bug 30920: (follow-up) Manually flush caches in tests
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2023-03-10 16:38:23 UTC
Size:
2.89 KB
patch
obsolete
>From a2832cc2dd53c36a05b1115257e1a82e59fca069 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 10 Mar 2023 16:34:26 +0000 >Subject: [PATCH] Bug 30920: (follow-up) Manually flush caches in tests > >We can't rely on our cache flushing in either 'store' or 'delete' >triggers as t/lib/TestBuilder::build_object skips the Koha::Object store >and uses direct DB inserts in preference. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Item.t | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index f42f8b03a1..bd56d19623 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -1358,6 +1358,10 @@ subtest 'columns_to_str' => sub { > $cache->clear_from_cache("MarcStructure-0-"); > $cache->clear_from_cache("MarcStructure-1-"); > $cache->clear_from_cache("MarcSubfieldStructure-"); >+ $cache->clear_from_cache("libraries:name"); >+ $cache->clear_from_cache("itemtype:description:en"); >+ $cache->clear_from_cache("cn_sources:description"); >+ $cache->clear_from_cache("AV_descriptions:LOST"); > > # Creating subfields 'é', 'è' that are not linked with a kohafield > Koha::MarcSubfieldStructures->search( >@@ -1436,9 +1440,12 @@ subtest 'columns_to_str' => sub { > $cache->clear_from_cache("MarcStructure-0-"); > $cache->clear_from_cache("MarcStructure-1-"); > $cache->clear_from_cache("MarcSubfieldStructure-"); >+ $cache->clear_from_cache("libraries:name"); >+ $cache->clear_from_cache("itemtype:description:en"); >+ $cache->clear_from_cache("cn_sources:description"); >+ $cache->clear_from_cache("AV_descriptions:LOST"); > > $schema->storage->txn_rollback; >- > }; > > subtest 'strings_map() tests' => sub { >@@ -1453,6 +1460,9 @@ subtest 'strings_map() tests' => sub { > $cache->clear_from_cache("MarcStructure-0-"); > $cache->clear_from_cache("MarcStructure-1-"); > $cache->clear_from_cache("MarcSubfieldStructure-"); >+ $cache->clear_from_cache("libraries:name"); >+ $cache->clear_from_cache("itemtype:description:en"); >+ $cache->clear_from_cache("cn_sources:description"); > > # Recreating subfields just to be sure tests will be ok > # 1 => av (LOST) >@@ -1561,7 +1571,7 @@ subtest 'strings_map() tests' => sub { > class_split_rule => $class_split_rule->class_split_rule, > } > } >- ); >+ )->store(); > > $item->set( > { >@@ -1633,6 +1643,9 @@ subtest 'strings_map() tests' => sub { > $cache->clear_from_cache("MarcStructure-0-"); > $cache->clear_from_cache("MarcStructure-1-"); > $cache->clear_from_cache("MarcSubfieldStructure-"); >+ $cache->clear_from_cache("libraries:name"); >+ $cache->clear_from_cache("itemtype:description:en"); >+ $cache->clear_from_cache("cn_sources:description"); > > $schema->storage->txn_rollback; > }; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30920
:
135771
|
136292
|
136293
|
144817
|
144818
|
144819
|
148064
|
148065
|
148066
|
148067
|
148087
|
148088
|
148089
|
148090
|
148091
|
148092
|
148093
| 148094