Bugzilla – Attachment 1481 Details for
Bug 3651
Require patron login to send shelves and baskets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bugfix
0001--bug-3651-sending-baskets-and-shelves.patch (text/plain), 3.87 KB, created by
Chris Cormack
on 2009-09-21 13:10:00 UTC
(
hide
)
Description:
bugfix
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-09-21 13:10:00 UTC
Size:
3.87 KB
patch
obsolete
>From 232dce944fe87e44af3f74be28f6192f4d0bea6c Mon Sep 17 00:00:00 2001 >From: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com> >Date: Mon, 21 Sep 2009 15:08:27 +0200 >Subject: [PATCH] (bug #3651) sending baskets and shelves >Content-Type: text/plain; charset="utf-8" > >this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list. >--- > .../opac-tmpl/prog/en/modules/opac-sendbasket.tmpl | 2 +- > .../opac-tmpl/prog/en/modules/opac-sendshelf.tmpl | 2 +- > opac/opac-sendbasket.pl | 10 ++++++++-- > opac/opac-sendshelf.pl | 5 +++++ > 4 files changed, 15 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tmpl >index b55760a..5d95063 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tmpl >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tmpl >@@ -5,7 +5,7 @@ Your Cart > <HEADER> > Hi, > >-Here is your cart, sent from our online catalog. >+<!-- TMPL_VAR NAME="firstname" --> <!-- TMPL_VAR NAME="surname" --> sent you a cart from our online catalog. > > Please note that the attached file is a MARC biblographic records file > which can be imported into a Personal Bibliographic Software like EndNote, >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tmpl >index 61ae453..3d150e3 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tmpl >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tmpl >@@ -5,7 +5,7 @@ Your List : <!-- TMPL_VAR NAME="shelfname" --> > <HEADER> > Hi, > >-Here is your list called <!-- TMPL_VAR NAME="shelfname" -->, sent from our online catalog. >+<!-- TMPL_VAR NAME="firstname" --> <!-- TMPL_VAR NAME="surname" -->, sent you from our online catalog, the virtual shelf called : <!-- TMPL_VAR NAME="shelfname" -->. > > Please note that the attached file is a MARC biblographic records file > which can be imported into a Personal Bibliographic Software like EndNote, >diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl >index f17bb71..846cd5e 100755 >--- a/opac/opac-sendbasket.pl >+++ b/opac/opac-sendbasket.pl >@@ -28,6 +28,7 @@ use C4::Items; > use C4::Auth; > use C4::Output; > use C4::Biblio; >+use C4::Members; > > my $query = new CGI; > >@@ -36,7 +37,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user ( > template_name => "opac-sendbasketform.tmpl", > query => $query, > type => "opac", >- authnotrequired => 1, >+ authnotrequired => 0, > flagsrequired => { borrow => 1 }, > } > ); >@@ -92,10 +93,15 @@ if ( $email_add ) { > } > > my $resultsarray = \@results; >+ >+ my $user = GetMember($borrowernumber); >+ > $template2->param( > BIBLIO_RESULTS => $resultsarray, > email_sender => $email_sender, >- comment => $comment >+ comment => $comment, >+ firstname => $user->{firstname}, >+ surname => $user->{surname}, > ); > > # Getting template result >diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl >index 7fe25af..13eef9f 100755 >--- a/opac/opac-sendshelf.pl >+++ b/opac/opac-sendshelf.pl >@@ -31,6 +31,7 @@ use C4::Biblio; > use C4::Items; > use C4::Output; > use C4::VirtualShelves; >+use C4::Members; > > my $query = new CGI; > >@@ -97,11 +98,15 @@ if ( $email ) { > push( @results, $dat ); > } > >+ my $user = GetMember($borrowernumber); >+ > $template2->param( > BIBLIO_RESULTS => \@results, > email_sender => $email_from, > comment => $comment, > shelfname => $shelf[1], >+ firstname => $user->{firstname}, >+ surname => $user->{surname}, > ); > > # Getting template result >-- >1.6.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3651
:
1481
|
6955
|
6968