Attachment 148126 Details for Bug 33198 – Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds

[patch] Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds

Bug-33198-Dont-calculate-pickup-locations-per-bib-.patch (text/plain), 1.27 KB, created by Tomás Cohen Arazi (tcohen) on 2023-03-13 15:36:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-03-13 15:36:30 UTC

Size: 1.27 KB

patch

obsolete

>From 70206ca137f0a67feb444ae5a2709e98fc662745 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 10 Mar 2023 18:44:21 +0000
>Subject: [PATCH] Bug 33198: Don't calculate pickup locations per bib unless
> placing multiple holds
>
>For single bibs we use an ajax select2 dropdown, and we don't use this
>value
>
>To test:
>1 - Place some holds on single bibs
>2 - Confirm dropdowns for pickup location work as expected
>3 - Do the same for multiple bibs selected from search results
>4 - Apply patch
>5 - Confirm there is no change after the patch
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> reserve/request.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 0c37d6e4c15..fce3a6e5b0b 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -681,7 +681,7 @@ if (   ( $findborrower && $borrowernumber_hold || $findclub && $club_hold )
>             $template->param( reserveloop => \@reserveloop );
>         }
> 
>-        if ( $patron ) {
>+        if ( $patron && $multi_hold ) {
>             # Add the valid pickup locations
>             my @pickup_locations = $biblio->pickup_locations({ patron => $patron })->as_list;
>             $biblioloopiter{pickup_locations} = \@pickup_locations;
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33198: 148096 | 148126 | 148532