Bugzilla – Attachment 148161 Details for
Bug 33216
SIP fee paid messages explode if payment registers are enabled and the SIP account has no register
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33216: Catch and handle all Koha exceptions
Bug-33216-Catch-and-handle-all-Koha-exceptions.patch (text/plain), 1016 bytes, created by
Kyle M Hall (khall)
on 2023-03-14 12:28:59 UTC
(
hide
)
Description:
Bug 33216: Catch and handle all Koha exceptions
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-03-14 12:28:59 UTC
Size:
1016 bytes
patch
obsolete
>From 09433b6e12471d2919eb8b37614974b824240315 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Tue, 14 Mar 2023 08:28:30 -0400 >Subject: [PATCH] Bug 33216: Catch and handle all Koha exceptions > >--- > C4/SIP/ILS/Transaction/FeePayment.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/FeePayment.pm b/C4/SIP/ILS/Transaction/FeePayment.pm >index 85d58cdc23..7574a82305 100644 >--- a/C4/SIP/ILS/Transaction/FeePayment.pm >+++ b/C4/SIP/ILS/Transaction/FeePayment.pm >@@ -84,9 +84,9 @@ sub pay { > $pay_response = $account->pay($pay_options); > } > catch { >- if ( ref($_) eq 'Koha::Exceptions::Account::RegisterRequired' ) { >- $ok = 0; >- $error = q{SIP account must be associated with a register for 'fee paid' messages to succeed}; >+ if ( ref($_) =~ /^Koha::Exceptions/ ) { >+ $ok = 0; >+ $error = $_->description; > } > else { > $_->rethrow; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33216
:
148157
|
148161
|
149755
|
149757
|
149795
|
149796