Bugzilla – Attachment 148220 Details for
Bug 32878
Make it impossible to renew the item if it has active item level hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32878: (follow-up) Exclude non_priority holds
Bug-32878-follow-up-Exclude-nonpriority-holds.patch (text/plain), 1004 bytes, created by
Martin Renvoize (ashimema)
on 2023-03-15 15:26:53 UTC
(
hide
)
Description:
Bug 32878: (follow-up) Exclude non_priority holds
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-03-15 15:26:53 UTC
Size:
1004 bytes
patch
obsolete
>From e1a25791972c08ed806687297f17fc9fa778aa05 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 15 Mar 2023 15:24:32 +0000 >Subject: [PATCH] Bug 32878: (follow-up) Exclude non_priority holds > >This patch filters out non_priorty holds in the on_reserve condition. > >Test plan >1) Run t/db_dependant/Holds.t >2) Note it fails without this patch >3) Apply patch >4) Re-run the above test, note it now passes >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 6677b82416..e190019ae1 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2957,7 +2957,7 @@ sub CanBookBeRenewed { > > # There is an item level hold on this item, no other item can fill the hold > return ( 0, "on_reserve" ) >- if ( $item->current_holds->count ); >+ if ( $item->current_holds->search( { non_priority => 0 } )->count ); > > my $fillable_holds = Koha::Holds->search( > { >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32878
:
146145
|
146166
|
146740
|
146741
|
146742
|
146830
|
146833
|
146834
|
146835
|
148220
|
148223