Attachment 148230 Details for Bug 33060 – Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

[patch] Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

Bug-33060-Fix-yesno-setting-to-10-in-system-prefer.patch (text/plain), 1.94 KB, created by Martin Renvoize (ashimema) on 2023-03-15 16:22:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-03-15 16:22:03 UTC

Size: 1.94 KB

patch

obsolete

>From ceb77b844d87be6e856b4104d85192588c04ad07 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 23 Feb 2023 22:16:56 +0000
>Subject: [PATCH] Bug 33060: Fix yes/no setting to 1/0 in system preference
> YAML files
>
>Boolean system preferences need to use 1 and 0 for true and false,
>not yes and no now. This fixes a few occurences that have
>been added in the last release:
>
>* EnableItemGroups
>* EnableItemGroupHolds
>* ArticleRequestsOpacHostRedirection
>* UseLocationAsAQInSIP
>
>To test:
>* Make sure these preferences save to the db as 0/1 as expected.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/admin/preferences/circulation.pref    | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index df40f15c46..e12abc7534 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -1234,8 +1234,8 @@ Circulation:
>         -
>             - pref: ArticleRequestsOpacHostRedirection
>               choices:
>-                  yes: Enable
>-                  no: Disable
>+                  1: Enable
>+                  0: Disable
>             - " redirection from child to host based on MARC21 773$w when the child has no items when requesting articles on the Opac."
>         -
>             - pref: ArticleRequestsLinkControl
>@@ -1356,8 +1356,8 @@ Circulation:
>             - Use
>             - pref: UseLocationAsAQInSIP
>               choices:
>-                  yes: permanent_location
>-                  no: homebranch
>+                  1: permanent_location
>+                  0: homebranch
>             - for AQ field in SIP protocol.
> 
>     Curbside pickup module:
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 33060: 147274 | 147432 | 148230