Bugzilla – Attachment 148255 Details for
Bug 32180
ERM - Mandatory fields don't have the 'required' class on the label
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32180: Add required class to labels in ERM
Bug-32180-Add-required-class-to-labels-in-ERM.patch (text/plain), 6.72 KB, created by
Martin Renvoize (ashimema)
on 2023-03-16 09:58:55 UTC
(
hide
)
Description:
Bug 32180: Add required class to labels in ERM
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-03-16 09:58:55 UTC
Size:
6.72 KB
patch
obsolete
>From 6e5fba0767ca1a9bf4289f036e6ba5bdc60ff90a Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 15 Mar 2023 20:39:27 +0000 >Subject: [PATCH] Bug 32180: Add required class to labels in ERM > >To test: >1. Apply patch, yarn build >2. Add/edit Agreemnets, make sure all required fields have a red 'required' label >3. Check 'Add new period', 'Add new user', 'Add new license', 'Add new related agreement'. >4. Add/edit Licenses, make sure all required fields have a red 'required' label. > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/js/vue/components/ERM/AgreementLicenses.vue | 4 ++-- > .../prog/js/vue/components/ERM/AgreementRelationships.vue | 8 ++++++-- > .../prog/js/vue/components/ERM/AgreementsFormAdd.vue | 4 ++-- > .../prog/js/vue/components/ERM/LicensesFormAdd.vue | 8 +++++--- > .../prog/js/vue/components/ERM/UserRoles.vue | 2 +- > 5 files changed, 16 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementLicenses.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementLicenses.vue >index a05b2893c2..c64d571f14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementLicenses.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementLicenses.vue >@@ -16,7 +16,7 @@ > </legend> > <ol> > <li> >- <label :for="`license_id_${counter}`" >+ <label :for="`license_id_${counter}`" class="required" > >{{ $__("License") }}:</label > > > <v-select >@@ -38,7 +38,7 @@ > <span class="required">{{ $__("Required") }}</span> > </li> > <li> >- <label :for="`license_status_${counter}`" >+ <label :for="`license_status_${counter}`" class="required" > >{{ $__("Status") }}:</label > > > <v-select >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementRelationships.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementRelationships.vue >index ce68103759..0465bb867e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementRelationships.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementRelationships.vue >@@ -16,7 +16,9 @@ > </legend> > <ol> > <li> >- <label :for="`related_agreement_id_${counter}`" >+ <label >+ :for="`related_agreement_id_${counter}`" >+ class="required" > >{{ $__("Related agreement") }}: > </label> > <v-select >@@ -38,7 +40,9 @@ > <span class="required">{{ $__("Required") }}</span> > </li> > <li> >- <label :for="`related_agreement_relationship_${counter}`" >+ <label >+ :for="`related_agreement_relationship_${counter}`" >+ class="required" > >{{ $__("Relationship") }}: > </label> > <v-select >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >index f30580913b..bafe8ee118 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >@@ -11,7 +11,7 @@ > <fieldset class="rows"> > <ol> > <li> >- <label class="required" for="agreement_name" >+ <label for="agreement_name" class="required" > >{{ $__("Agreement name") }}:</label > > > <input >@@ -49,7 +49,7 @@ > /> > </li> > <li> >- <label for="agreement_status" >+ <label for="agreement_status" class="required" > >{{ $__("Status") }}:</label > > > <v-select >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue >index 004d77dd4f..272253cadf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue >@@ -37,7 +37,9 @@ > /> > </li> > <li> >- <label for="license_description" >+ <label >+ for="license_description" >+ class="required" > >{{ $__("Description") }}: > </label> > <textarea >@@ -53,7 +55,7 @@ > }}</span> > </li> > <li> >- <label for="license_type" >+ <label for="license_type" class="required" > >{{ $__("Type") }}:</label > > > <v-select >@@ -77,7 +79,7 @@ > }}</span> > </li> > <li> >- <label for="license_status" >+ <label for="license_status" class="required" > >{{ $__("Status") }}:</label > > > <v-select >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UserRoles.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UserRoles.vue >index e7725768b9..20491d794a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UserRoles.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UserRoles.vue >@@ -29,7 +29,7 @@ > >) > </li> > <li> >- <label :for="`user_role_${counter}`" >+ <label :for="`user_role_${counter}`" class="required" > >{{ $__("Role") }}:</label > > > <v-select >-- >2.39.2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=148255">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32180
:
148246
|
148253
| 148255