Bugzilla – Attachment 148334 Details for
Bug 28641
ILLHiddenRequestStatuses does not consider custom statuses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses
Bug-28641-ILLHiddenRequestStatuses-does-not-consid.patch (text/plain), 1.67 KB, created by
Pedro Amorim
on 2023-03-17 12:22:16 UTC
(
hide
)
Description:
Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-03-17 12:22:16 UTC
Size:
1.67 KB
patch
obsolete
>From 3760f9d7387a112be5a3a3901f36c49215e6f2cc Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 2 Feb 2023 17:55:10 +0000 >Subject: [PATCH] Bug 28641: ILLHiddenRequestStatuses does not consider custom > statuses > >This patch adds the status_alias column to the ILLHiddenRequestStatuses sys pref check. >Because requests will have status_alias NULL by default, we also check for that. > >Test plan: >Create multiple ILL requests of different backends and place them in different status (NEW, COMP, REQ, etc) >Create multiple ILLSTATUS entries >Add and remove a mix of both status and status_alias codes in ILLHiddenRequestStatuses and refresh the ILL requests page to confirm the result is according to expectation. > >Sponsored-by: PTFS Europe > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/REST/V1/Illrequests.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm >index 82c5b5dd08..5b20516836 100644 >--- a/Koha/REST/V1/Illrequests.pm >+++ b/Koha/REST/V1/Illrequests.pm >@@ -64,7 +64,15 @@ sub list { > # If necessary, only get those from a specified patron > my @requests = Koha::Illrequests->search({ > $hidden_statuses >- ? ( status => { 'not in' => $hidden_statuses } ) >+ ? ( >+ -and => { >+ status => { 'not in' => $hidden_statuses }, >+ status_alias => [ -or => >+ { 'not in' => $hidden_statuses }, >+ { '=' => undef } >+ ] >+ } >+ ) > : (), > $args->{borrowernumber} > ? ( borrowernumber => $args->{borrowernumber} ) >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28641
:
146023
|
146522
|
148334
|
148852