Bugzilla – Attachment 148379 Details for
Bug 19361
Linking an authorised value category to a field in a framework can lose data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19361: (QA follow-up) Make sure translatable string is wrapped in double quotes
Bug-19361-QA-follow-up-Make-sure-translatable-stri.patch (text/plain), 1.60 KB, created by
Katrin Fischer
on 2023-03-17 17:48:19 UTC
(
hide
)
Description:
Bug 19361: (QA follow-up) Make sure translatable string is wrapped in double quotes
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-03-17 17:48:19 UTC
Size:
1.60 KB
patch
obsolete
>From fc4b6899c1eebeefa52d6c8214f5671b1886373a Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Fri, 17 Mar 2023 16:10:26 +0000 >Subject: [PATCH] Bug 19361: (QA follow-up) Make sure translatable string is > wrapped in double quotes > >This fixes the QA script complaint: > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc > FAIL forbidden patterns > forbidden pattern: simple-quote string (line 125) > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 6df08dbef6..7fc306aa64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -122,7 +122,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > $node.append( '<option value="' + authval.value + '"' + selected + '>' + authval.lib + '</option>' ); > } ); > if( !matched ){ >- $node.append( '<option value="' + value + '" selected="selected">' + value + _(' (Not in authorised values list) ') + '</option>' ); >+ $node.append( "<option value='" + value + "' selected='selected'>" + value + " " + _("(Not in authorised values list)") + " " + "</option>" ); > } > $node.val( this.text ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19361
:
67385
|
67652
|
67655
|
67657
|
67658
|
67955
|
105848
|
142158
|
142159
|
142208
|
142209
|
148377
|
148378
| 148379 |
148380