Attachment 148385 Details for Bug 33265 – Bug 33265: Clean up serial links on serial edit page

[patch] Bug 33265: Clean up serial links on serial edit page

Bug-33265-Clean-up-serial-links-on-serial-edit-pag.patch (text/plain), 3.91 KB, created by Lucas Gass (lukeg) on 2023-03-17 20:56:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-03-17 20:56:52 UTC

Size: 3.91 KB

patch

obsolete

>From dc6c1aafc974ef1acfb723236bdb8af88a1147e8 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 17 Mar 2023 20:47:09 +0000
>Subject: [PATCH] Bug 33265: Clean up serial links on serial edit page
>
>To test:
>1. Reviece a serial
>2. Notice the unstyled links:
>    * Serial collection #1
>    * Subscription #1
>    * Show biblio
>3. Apply pacth
>4. The links should now be styled.
>---
> .../prog/css/src/staff-global.scss            |  2 +-
> .../prog/en/modules/serials/serials-edit.tt   | 22 +++++++++++--------
> 2 files changed, 14 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 9b1534fdbd..35cfce3977 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -311,7 +311,7 @@ aside {
>     }
> }
> 
>-#menu, #navmenulist {
>+#menu, #navmenulist, #serialmenu {
>     background-color: #e6e6e6;
>     display: block;
>     padding: 1em 0 1em 0;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>index fdea3ee1be..6caa48e25a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>@@ -465,17 +465,21 @@ $(document).ready(function() {
>         <div class="col-sm-2 col-sm-pull-10">
>             <aside>
>                 [% INCLUDE 'serials-menu.inc' %]
>-                <ul>
>-                    [% FOREACH subscription IN subscriptions %]
>-                        <li><a href="serials-collection.pl?subscriptionid=[% subscription.subscriptionid | uri %]" title="serial collection for [% subscription.bibliotitle | uri %]">Serial collection #[% subscription.subscriptionid | html %]</a></li>
>-                        <li><a href="subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]" title="detail of the subscription">Subscription #[% subscription.subscriptionid | html %]</a></li>
>-                        [% IF ( subscription.abouttoexpire ) %]
>-                            [% UNLESS subscription.closed %]
>-                                <li><a href="#" onclick="javascript:popup([% subscription.subscriptionid | html %])">Renew #[% subscription.subscriptionid | html %]</a></li>
>+                <div id="serialmenu">
>+                    <h5>Serial links</h5>
>+                    <ul>
>+                        [% FOREACH subscription IN subscriptions %]
>+                            <li><a href="serials-collection.pl?subscriptionid=[% subscription.subscriptionid | uri %]" title="Serial collection for [% subscription.subscriptionid | html %]">Serial collection #[% subscription.subscriptionid | html %]</a></li>
>+                            <li><a href="subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]" title="Detail of the subscription">Subscription #[% subscription.subscriptionid | html %]</a></li>
>+                            [% IF ( subscription.abouttoexpire ) %]
>+                                [% UNLESS subscription.closed %]
>+                                    <li><a href="#" onclick="javascript:popup([% subscription.subscriptionid | html %])">Renew #[% subscription.subscriptionid | html %]</a></li>
>+                                [% END %]
>                             [% END %]
>                         [% END %]
>-                    [% END %]
>-                    <li><a href="[% PROCESS biblio_a_href biblionumber => biblionumber %]" title="go to [% bibliotitle | html %]">Show biblio</a></li></ul>
>+                        <li><a href="[% PROCESS biblio_a_href biblionumber => biblionumber %]" title="Go to [% bibliotitle | html %]">Show bibliographic record</a></li>
>+                    </ul>
>+                </div>
>             </aside>
>         </div> 
>      </div> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33265: 148385 | 149128 | 149357