Attachment 148496 Details for Bug 25379 – Bug 25379: Add raw filter to circulation note on checkin page

[patch] Bug 25379: Add raw filter to circulation note on checkin page

Bug-25379-Add-raw-filter-to-circulation-note-on-ch.patch (text/plain), 2.14 KB, created by David Nind on 2023-03-21 23:02:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-03-21 23:02:23 UTC

Size: 2.14 KB

patch

obsolete

>From c62b40dd307729392ca4b29c53f969bd064e652b Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 17 Mar 2023 21:36:23 +0000
>Subject: [PATCH] Bug 25379: Add raw filter to circulation note on checkin page
>
>This is a consistency patch: we already allow adding HTML tags
>to the patron circulation note and the contents display
>correctly in the patron account and in the patron search results
>in the staff interface. But the HTML tags are printed on the
>checkins page.
>
>To test:
>* Add a circulation note including HTML tags to a patron
> Example: <h1>This patron is great!</h1>
>* Check an item out to this patron
>* Verify that the note displays formatted in patron search results
>* Verify that the note displays formatted in the patron record
>* Return the item
>* Verify the note shows the printed tags
>* Apply patch
>* Check item out again and check it in again
>* Verify the note now displays correctly in list of checkins
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 7596356df6..90630a11b3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -1290,7 +1290,7 @@
> </td>
> <td class="ci-note">
> [% IF ( riloo.patron.borrowernotes ) %]
>- [% riloo.patron.borrowernotes | html %]
>+ [% riloo.patron.borrowernotes | $raw %]
> [% END %]
> [% IF ( riloo.itemnote ) %]
> [% riloo.itemnote | html %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 25379: 104375 | 148387 | 148496 | 150395 | 150396