Attachment 148585 Details for Bug 33300 – Bug 33300: (follow-up) DBRev for existing databases

[patch] Bug 33300: (follow-up) DBRev for existing databases

Bug-33300-follow-up-DBRev-for-existing-databases.patch (text/plain), 2.45 KB, created by Fridolin Somers on 2023-03-23 07:17:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2023-03-23 07:17:28 UTC

Size: 2.45 KB

patch

obsolete

>From c614f2819da0cce5a3855696f14792ae373fd8ee Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 22 Mar 2023 21:14:43 -1000
>Subject: [PATCH] Bug 33300: (follow-up) DBRev for existing databases
>
>Test plan :
>1.1) Start from a Koha 22.05
>1.2) Upgrade to master
>=> Check the upgrade says :
>   Wrong system preference 'AutomaticWrongTransfer' renamed 'AutomaticConfirmTransfer'
>2.1) Start from a Koha 22.05
>2.2) Upgrade to 22.11
>2.3) Via interface change system preference 'AutomaticConfirmTransfer' and save
>2.4) Upgrade to master
>=> Check the upgrade says :
>   Wrong system preference 'AutomaticWrongTransfer' deleted
>---
> .../data/mysql/atomicupdate/bug_33300.pl      | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100755 installer/data/mysql/atomicupdate/bug_33300.pl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_33300.pl b/installer/data/mysql/atomicupdate/bug_33300.pl
>new file mode 100755
>index 0000000000..01b36b2c61
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_33300.pl
>@@ -0,0 +1,32 @@
>+use Modern::Perl;
>+
>+return {
>+    bug_number => "33300",
>+    description => "Fix missing wrong system preference 'AutomaticWrongTransfer'",
>+    up => sub {
>+        my ($args) = @_;
>+        my ($dbh, $out) = @$args{qw(dbh out)};
>+        my ($wrong_syspref_exists) = $dbh->selectrow_array(q{
>+            SELECT COUNT(*) FROM systempreferences WHERE variable='AutomaticWrongTransfer'
>+        });
>+        if ($wrong_syspref_exists) {
>+            # Correct preference may have been generated via interface
>+            my ($correct_syspref_exists) = $dbh->selectrow_array(q{
>+                SELECT COUNT(*) FROM systempreferences WHERE variable='AutomaticConfirmTransfer'
>+            });
>+            if ( $correct_syspref_exists ) {
>+                $dbh->do(q{
>+                    DELETE FROM systempreferences WHERE variable='AutomaticWrongTransfer'
>+                });
>+                say $out "Wrong system preference 'AutomaticWrongTransfer' deleted";
>+            } else {
>+                $dbh->do(q{
>+                    UPDATE systempreferences SET variable='AutomaticConfirmTransfer' WHERE variable='AutomaticWrongTransfer'
>+                });
>+                say $out "Wrong system preference 'AutomaticWrongTransfer' renamed 'AutomaticConfirmTransfer'";
>+            }
>+        } else {
>+            say $out "Wrong system preference 'AutomaticWrongTransfer' does not exist";
>+        }
>+    },
>+};
>-- 
>2.39.0

Actions: View | Diff | Splinter Review

Attachments on bug 33300: 148505 | 148508 | 148581 | 148585 | 149721 | 149793 | 149794 | 151246 | 151247 | 151248