Bugzilla – Attachment 148633 Details for
Bug 32830
Fix cataloguing/value_builder/unimarc_field_116.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32830: Fix cataloguing/value_builder/unimarc_field_116.pl
Bug-32830-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.65 KB, created by
Marcel de Rooy
on 2023-03-24 08:29:33 UTC
(
hide
)
Description:
Bug 32830: Fix cataloguing/value_builder/unimarc_field_116.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-03-24 08:29:33 UTC
Size:
1.65 KB
patch
obsolete
>From 8c3e6e8aa88de77e3970497c75cfbeaf13d23c74 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2023 11:58:52 +0100 >Subject: [PATCH] Bug 32830: Fix cataloguing/value_builder/unimarc_field_116.pl >Content-Type: text/plain; charset=utf-8 > >Use event parameter > >This is part of the refactoring happening in bug 30975 > >Test plan: >1. Verify that the plugin continues to work as before > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > cataloguing/value_builder/unimarc_field_116.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_116.pl b/cataloguing/value_builder/unimarc_field_116.pl >index 8781a5da2f..a5ca0f6117 100755 >--- a/cataloguing/value_builder/unimarc_field_116.pl >+++ b/cataloguing/value_builder/unimarc_field_116.pl >@@ -32,9 +32,10 @@ sub plugin_javascript { > my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> >-function Clic$field_number(i) { >- defaultvalue=document.getElementById(\"$field_number\").value; >- window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_116.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_116\",'width=1200,height=600,toolbar=false,scrollbars=yes'); >+function Clic$field_number(event) { >+ event.preventDefault(); >+ defaultvalue=document.getElementById(event.data.id).value; >+ window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_116.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_116\",'width=1200,height=600,toolbar=false,scrollbars=yes'); > > } > </script> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32830
:
146095
|
146766
|
148618
| 148633