Attachment 148634 Details for Bug 32831 – Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl

[patch] Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl

Bug-32831-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.65 KB, created by Marcel de Rooy on 2023-03-24 08:31:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-03-24 08:31:08 UTC

Size: 1.65 KB

patch

obsolete

>From 0457b165880db1ddcd34e1173451bd8115beb4d8 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:52 +0100
>Subject: [PATCH] Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl
>Content-Type: text/plain; charset=utf-8
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> cataloguing/value_builder/unimarc_field_117.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_117.pl b/cataloguing/value_builder/unimarc_field_117.pl
>index 9286826145..250f9a0602 100755
>--- a/cataloguing/value_builder/unimarc_field_117.pl
>+++ b/cataloguing/value_builder/unimarc_field_117.pl
>@@ -32,9 +32,10 @@ sub plugin_javascript {
> my ($dbh,$record,$tagslib,$field_number) = @_;
> my $res="
> <script>
>-function Clic$field_number(i) {
>-	defaultvalue=document.getElementById(\"$field_number\").value;
>-	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_117.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_117\",'width=600,height=225,toolbar=false,scrollbars=yes');
>+function Clic$field_number(event) {
>+    event.preventDefault();
>+    defaultvalue=document.getElementById(event.data.id).value;
>+    newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_117.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_117\",'width=600,height=225,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32831: 146096 | 146767 | 148619 | 148634