Attachment 148636 Details for Bug 32833 – Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

[patch] Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Bug-32833-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.67 KB, created by Marcel de Rooy on 2023-03-24 08:34:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-03-24 08:34:25 UTC

Size: 1.67 KB

patch

obsolete

>From 7cae9477429cdf575295c71b75f691a342ac8455 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:52 +0100
>Subject: [PATCH] Bug 32833: Fix
> cataloguing/value_builder/unimarc_field_121a.pl
>Content-Type: text/plain; charset=utf-8
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> cataloguing/value_builder/unimarc_field_121a.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_121a.pl b/cataloguing/value_builder/unimarc_field_121a.pl
>index e1967e38ca..b5d2d040f9 100755
>--- a/cataloguing/value_builder/unimarc_field_121a.pl
>+++ b/cataloguing/value_builder/unimarc_field_121a.pl
>@@ -33,9 +33,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_;
> my $function_name= $field_number;
> my $res="
> <script>
>-function Clic$function_name(i) {
>-	defaultvalue=document.getElementById(\"$field_number\").value;
>-	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_121a.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_121a\",'width=1210,height=750,toolbar=false,scrollbars=yes');
>+function Clic$function_name(event) {
>+    event.preventDefault();
>+    defaultvalue=document.getElementById(event.data.id).value;
>+    newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_121a.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_121a\",'width=1210,height=750,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32833: 146098 | 146769 | 148621 | 148636