Bugzilla – Attachment 148675 Details for
Bug 30930
Ability to change authority type while editing record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30930: (QA follow-up) Tidy code block
Bug-30930-QA-follow-up-Tidy-code-block.patch (text/plain), 1.92 KB, created by
Kyle M Hall (khall)
on 2023-03-24 16:21:03 UTC
(
hide
)
Description:
Bug 30930: (QA follow-up) Tidy code block
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-03-24 16:21:03 UTC
Size:
1.92 KB
patch
obsolete
>From 044f9472d5a011994f58e94e3e98a1f6f0702fea Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 24 Mar 2023 12:13:23 -0400 >Subject: [PATCH] Bug 30930: (QA follow-up) Tidy code block > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > authorities/authorities.pl | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 34554b5ecee..501a012d241 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -631,19 +631,24 @@ if ($op eq "add") { > } > exit; > } else { >-if ($op eq "duplicate") >- { >- $authid = ""; >- } >- if($changed_authtype eq "changed"){ >- $record = TransformHtmlToMarc( $input, 0 ); >- } >+ if ( $op eq "duplicate" ) { >+ $authid = ""; >+ } > >- build_tabs ($template, $record, $dbh, $input); >- build_hidden_data; >- $template->param(oldauthtypetagfield=>$oldauthtypetagfield, oldauthtypetagsubfield=>$oldauthtypetagsubfield, >- oldauthnumtagfield=>$oldauthnumtagfield, oldauthnumtagsubfield=>$oldauthnumtagsubfield, >- authid => $authid , authtypecode=>$authtypecode, ); >+ if ( $changed_authtype eq "changed" ) { >+ $record = TransformHtmlToMarc( $input, 0 ); >+ } >+ >+ build_tabs( $template, $record, $dbh, $input ); >+ build_hidden_data; >+ $template->param( >+ oldauthtypetagfield => $oldauthtypetagfield, >+ oldauthtypetagsubfield => $oldauthtypetagsubfield, >+ oldauthnumtagfield => $oldauthnumtagfield, >+ oldauthnumtagsubfield => $oldauthnumtagsubfield, >+ authid => $authid, >+ authtypecode => $authtypecode, >+ ); > } > > my $authority_types = Koha::Authority::Types->search( {}, { order_by => ['authtypetext'] } ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30930
:
135851
|
146555
|
146969
|
148674
| 148675