Bugzilla – Attachment 148702 Details for
Bug 32838
Fix cataloguing/value_builder/unimarc_field_123e.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32838: Fix cataloguing/value_builder/unimarc_field_123e.pl
Bug-32838-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.58 KB, created by
David Nind
on 2023-03-25 17:56:54 UTC
(
hide
)
Description:
Bug 32838: Fix cataloguing/value_builder/unimarc_field_123e.pl
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-03-25 17:56:54 UTC
Size:
1.58 KB
patch
obsolete
>From df8c6d5f4fa05ee10ff332a5b9d08f0192b4b5c8 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2023 11:58:52 +0100 >Subject: [PATCH] Bug 32838: Fix > cataloguing/value_builder/unimarc_field_123e.pl > >Use event parameter > >This is part of the refactoring happening in bug 30975 > >Test plan: >1. Verify that the plugin continues to work as before > >Signed-off-by: David Nind <david@davidnind.com> >--- > cataloguing/value_builder/unimarc_field_123e.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_123e.pl b/cataloguing/value_builder/unimarc_field_123e.pl >index 50865fb2eb..0ca2f9c14c 100755 >--- a/cataloguing/value_builder/unimarc_field_123e.pl >+++ b/cataloguing/value_builder/unimarc_field_123e.pl >@@ -32,9 +32,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >-function Clic$function_name(i) { >- defaultvalue=document.getElementById(\"$field_number\").value; >- newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_123g.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_123g\",'width=1000,height=375,toolbar=false,scrollbars=yes'); >+function Clic$function_name(event) { >+ event.preventDefault(); >+ defaultvalue=document.getElementById(event.data.id).value; >+ newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_123g.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_123g\",'width=1000,height=375,toolbar=false,scrollbars=yes'); > > } > </script> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32838
:
146103
|
146774
|
148702
|
148858