Attachment 148766 Details for Bug 33342 – Bug 33342: Assigment in if clause sets invalid marc framework

[patch] Bug 33342: Assigment in if clause sets invalid marc framework

Bug-33342-Assigment-in-if-clause-sets-invalid-marc.patch (text/plain), 1.10 KB, created by David Gustafsson on 2023-03-27 13:11:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Gustafsson

Created: 2023-03-27 13:11:52 UTC

Size: 1.10 KB

patch

obsolete

>From aa9a09e67e2944a56aa40bcb9b6a612d48938957 Mon Sep 17 00:00:00 2001
>From: David Gustafsson <david.gustafsson@ub.gu.se>
>Date: Mon, 27 Mar 2023 15:06:29 +0200
>Subject: [PATCH] Bug 33342: Assigment in if clause sets invalid marc framework
>
>In a follow up in bug 15869 an if clause is added where "=" is
>used instead of "eq" in effect setting an invalid marc famework
>for the record. Fix this by using the correct operator.
>---
> tools/manage-marc-import.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl
>index e48b4790291..83e8bcca0e3 100755
>--- a/tools/manage-marc-import.pl
>+++ b/tools/manage-marc-import.pl
>@@ -90,7 +90,7 @@ if ($op eq "") {
> } elsif ($op eq "commit-batch") {
>     my $frameworkcode = $input->param('framework');
>     my $overlay_framework = $input->param('overlay_framework');
>-    $overlay_framework = undef if $overlay_framework = '_USE_ORIG';
>+    $overlay_framework = undef if $overlay_framework eq '_USE_ORIG';
>     try {
>         my $job_id = Koha::BackgroundJob::MARCImportCommitBatch->new->enqueue(
>             {
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 33342: 148766 | 148822