Attachment 148845 Details for Bug 32867 – Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

[patch] Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

Bug-32867-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.13 KB, created by David Nind on 2023-03-28 19:01:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-03-28 19:01:28 UTC

Size: 1.13 KB

patch

obsolete

>From 37e088bb68166fcd3b827f46b22ff40c915539dc Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:54 +0100
>Subject: [PATCH] Bug 32867: Fix
> cataloguing/value_builder/unimarc_field_146i.pl
>
>Remove unnecessary call to event.preventDefault()
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> cataloguing/value_builder/unimarc_field_146i.pl | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_146i.pl b/cataloguing/value_builder/unimarc_field_146i.pl
>index 609218db4e..1833a36f48 100755
>--- a/cataloguing/value_builder/unimarc_field_146i.pl
>+++ b/cataloguing/value_builder/unimarc_field_146i.pl
>@@ -29,7 +29,6 @@ my $builder = sub {
>     return qq|
> <script>
> function Click$id(event) {
>-    event.preventDefault();
>     const value = document.getElementById(event.data.id).value;
>     const url = new URL('/cgi-bin/koha/cataloguing/plugin_launcher.pl', location);
>     url.searchParams.set('plugin_name', 'unimarc_field_146i.pl');
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32867: 146132 | 148845 | 150097