Attachment 148876 Details for Bug 32858 – Bug 32858: Fix cataloguing/value_builder/unimarc_field_128a.pl

[patch] Bug 32858: Fix cataloguing/value_builder/unimarc_field_128a.pl

Bug-32858-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.63 KB, created by Nick Clemens (kidclamp) on 2023-03-29 08:36:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-03-29 08:36:29 UTC

Size: 1.63 KB

patch

obsolete

>From 8b846a96189ab1f386c913ab245e189f242f16f3 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:54 +0100
>Subject: [PATCH] Bug 32858: Fix
> cataloguing/value_builder/unimarc_field_128a.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> cataloguing/value_builder/unimarc_field_128a.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_128a.pl b/cataloguing/value_builder/unimarc_field_128a.pl
>index 9f235e1e5d..e825f7c8bc 100755
>--- a/cataloguing/value_builder/unimarc_field_128a.pl
>+++ b/cataloguing/value_builder/unimarc_field_128a.pl
>@@ -32,9 +32,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_;
> my $function_name= $field_number;
> my $res="
> <script>
>-function Clic$function_name(i) {
>-	defaultvalue=document.getElementById(\"$field_number\").value;
>-	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_128a.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_128a\",'width=1000,height=375,toolbar=false,scrollbars=yes');
>+function Clic$function_name(event) {
>+    event.preventDefault();
>+    defaultvalue=document.getElementById(event.data.id).value;
>+    newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_128a.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_128a\",'width=1000,height=375,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32858: 146123 | 146794 | 148726 | 148876