Attachment 148877 Details for Bug 32859 – Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

[patch] Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

Bug-32859-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.64 KB, created by Nick Clemens (kidclamp) on 2023-03-29 08:37:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-03-29 08:37:28 UTC

Size: 1.64 KB

patch

obsolete

>From ba3dd06170d264ee656266a8a34cd9643a5c8aeb Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:54 +0100
>Subject: [PATCH] Bug 32859: Fix
> cataloguing/value_builder/unimarc_field_128b.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> cataloguing/value_builder/unimarc_field_128b.pl | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_128b.pl b/cataloguing/value_builder/unimarc_field_128b.pl
>index 7d2e215fb8..ee9f267398 100755
>--- a/cataloguing/value_builder/unimarc_field_128b.pl
>+++ b/cataloguing/value_builder/unimarc_field_128b.pl
>@@ -33,9 +33,11 @@ my ($dbh,$record,$tagslib,$field_number) = @_;
> my $function_name= $field_number;
> my $res="
> <script>
>-function Clic$function_name(i) {
>-	defaultvalue=document.getElementById(\"$field_number\").value;
>-	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_128b.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_128b\",'width=1000,height=375,toolbar=false,scrollbars=yes');
>+function Clic$function_name(event) {
>+    event.preventDefault();
>+    const id = event.data.id;
>+    defaultvalue=document.getElementById(id).value;
>+    newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_128b.pl&index=\" + id + \"&result=\"+defaultvalue,\"unimarc_field_128b\",'width=1000,height=375,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32859: 146124 | 146795 | 148727 | 148877