Attachment 149007 Details for Bug 32876 – Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl

[patch] Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl

Bug-32876-Fix-cataloguingvaluebuilderunimarcleader.patch (text/plain), 1.95 KB, created by David Nind on 2023-03-30 19:35:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-03-30 19:35:23 UTC

Size: 1.95 KB

patch

obsolete

>From 327e3750a2a5fabdf742afddb57c343e7a6955dd Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:55 +0100
>Subject: [PATCH] Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> cataloguing/value_builder/unimarc_leader.pl | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_leader.pl b/cataloguing/value_builder/unimarc_leader.pl
>index 838f5a88f0..d29ede7bfe 100755
>--- a/cataloguing/value_builder/unimarc_leader.pl
>+++ b/cataloguing/value_builder/unimarc_leader.pl
>@@ -33,17 +33,17 @@ sub plugin_javascript {
>     my $function_name = $field_number;
>     my $res           = "
> <script>
>-function Blur$function_name(subfield_managed) {
>-	var leader_length = document.getElementById(\"$field_number\").value.length;
>+function Blur$function_name(event) {
>+	var leader_length = document.getElementById(event.data.id).value.length;
>     if (leader_length != 24 && leader_length !=0) {
>         alert(_('leader has an incorrect size: ' + leader_length + ' instead of 24 chars'));
>     }
>-    return 1;
> }
> 
>-function Clic$function_name(i) {
>-	defaultvalue=document.getElementById(\"$field_number\").value;
>-	newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_leader.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_100\",'width=1000,height=600,toolbar=false,scrollbars=yes');
>+function Clic$function_name(event) {
>+    event.preventDefault();
>+    defaultvalue=document.getElementById(event.data.id).value;
>+    newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_leader.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_100\",'width=1000,height=600,toolbar=false,scrollbars=yes');
> 
> }
> </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32876: 146143 | 146810 | 149007 | 150091