Attachment 149008 Details for Bug 33375 – Bug 33375: Quote reserved keyword 'rank' in advanced editor

[patch] Bug 33375: Quote reserved keyword 'rank' in advanced editor

Bug-33375-Quote-reserved-keyword-rank-in-advanced-.patch (text/plain), 1.32 KB, created by David Cook on 2023-03-31 01:00:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2023-03-31 01:00:41 UTC

Size: 1.32 KB

patch

obsolete

>From d00278c884f3fac5719dd39e4f2b6ea683d9da49 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Fri, 31 Mar 2023 00:55:56 +0000
>Subject: [PATCH] Bug 33375: Quote reserved keyword 'rank' in advanced editor
>
>This change quotes the 'rank' keyword in the advanced editor,
>so that it doesn't cause fatal crashes when using MySQL 8
>
>Test plan:
>0. Apply patch and koha-plack --restart kohadev
>1. Enable advanced editor
>http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=EnableAdvancedCatalogingEditor
>2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl#new/
>3. Click on "Advanced" on the left nav
>4. Note that "LIBRARY OF CONGRESS" is ordered before "NATIONAL LIBRARY OF FRANCE"
>5. Rejoice!
>---
> cataloguing/editor.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/cataloguing/editor.pl b/cataloguing/editor.pl
>index 53152c01dd..3e09b3b09d 100755
>--- a/cataloguing/editor.pl
>+++ b/cataloguing/editor.pl
>@@ -78,7 +78,7 @@ my $dbh = C4::Context->dbh;
> $template->{VARS}->{z3950_servers} = $dbh->selectall_arrayref( q{
>     SELECT * FROM z3950servers
>     WHERE recordtype != 'authority' AND servertype = 'zed'
>-    ORDER BY rank,servername
>+    ORDER BY `rank`,servername
> }, { Slice => {} } );
> 
> output_html_with_http_headers $input, $cookie, $template->output;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33375: 149008 | 149056 | 149633