Bugzilla – Attachment 149059 Details for
Bug 33285
It should be possible to specify the separator used in runreport.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33285: (QA follow-up) add POD and fix some code style
Bug-33285-QA-follow-up-add-POD-and-fix-some-code-s.patch (text/plain), 1.30 KB, created by
Fridolin Somers
on 2023-03-31 22:22:49 UTC
(
hide
)
Description:
Bug 33285: (QA follow-up) add POD and fix some code style
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2023-03-31 22:22:49 UTC
Size:
1.30 KB
patch
obsolete
>From 8316d4d2f6ed6afa55e36073f0d7ef878b003918 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 31 Mar 2023 12:16:43 -1000 >Subject: [PATCH] Bug 33285: (QA follow-up) add POD and fix some code style > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > misc/cronjobs/runreport.pl | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/misc/cronjobs/runreport.pl b/misc/cronjobs/runreport.pl >index c8ba5bed08..debcf5a024 100755 >--- a/misc/cronjobs/runreport.pl >+++ b/misc/cronjobs/runreport.pl >@@ -87,7 +87,11 @@ Verbose. Without this flag set, only fatal errors are reported. > > =item B<--format> > >-Current options are text, html, csv, and tsv. At the moment, text and tsv both produce tab-separated tab-separated output. >+Current options are text, html, csv, and tsv. At the moment, text and tsv both produce tab-separated output. >+ >+=item B<--separator> >+ >+Separator character, only for csv format. Default to comma. > > =item B<--email> > >@@ -221,8 +225,8 @@ unless ($format) { > $format = 'text'; > } > >-if( $csv_separator ){ >- if( $format eq 'csv' ) { >+if ($csv_separator) { >+ if ( $format eq 'csv' ) { > $separator = "$csv_separator"; > } else { > print STDERR "Cannot specify separator if not using CSV format\n"; >-- >2.39.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33285
:
148435
|
148769
|
148770
|
148771
|
148775
|
149058
| 149059