Bugzilla – Attachment 149066 Details for
Bug 32548
Make illrequestattributes easily available to ILL notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32548: Replace while with map
Bug-32548-Replace-while-with-map.patch (text/plain), 1.02 KB, created by
Pedro Amorim
on 2023-04-01 18:12:28 UTC
(
hide
)
Description:
Bug 32548: Replace while with map
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-04-01 18:12:28 UTC
Size:
1.02 KB
patch
obsolete
>From 4ca96e2984bc46ebc06011dd90fa460fe795e36b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 31 Mar 2023 14:11:55 +0200 >Subject: [PATCH] Bug 32548: Replace while with map > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > Koha/Illrequest.pm | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 21e94660cae..7550f38250a 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -1651,11 +1651,9 @@ sub get_notice { > } > my $metastring = join("\n", @metaarray); > >- my $illrequestattributes = {}; >- my $attributes = $self->illrequestattributes; >- while ( my $attribute = $attributes->next ) { >- $illrequestattributes->{$attribute->type} = $attribute->value; >- } >+ my $illrequestattributes = { >+ map { $_->type => $_->value } $self->illrequestattributes->as_list >+ }; > > my $letter = C4::Letters::GetPreparedLetter( > module => 'ill', >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32548
:
147157
|
149034
|
149035
|
149064
|
149065
|
149066
|
150400
|
150401
|
150402