Bugzilla – Attachment 149107 Details for
Bug 33343
Password fields should have auto-completion off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33343: Web Server Allows Password Auto-Completion
Bug-33343-Web-Server-Allows-Password-Auto-Completi.patch (text/plain), 12.08 KB, created by
Hammat wele
on 2023-04-03 21:05:43 UTC
(
hide
)
Description:
Bug 33343: Web Server Allows Password Auto-Completion
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2023-04-03 21:05:43 UTC
Size:
12.08 KB
patch
obsolete
>From 32f051b5ac9d3af4b698d0ecb5d84d1cc032eec0 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Mon, 3 Apr 2023 21:04:28 +0000 >Subject: [PATCH] Bug 33343: Web Server Allows Password Auto-Completion > >This patch adds 'autocomplete=off' to all password type fields in the OPAC > >To test: >1. Apply the patch >2. Visit http://master/cgi-bin/koha/opac-main.pl >3. Inspect the page > --> Confirm html shows autocomplete off on the password field >4. Click on Log in (without filling any field) >5. Repeat step 3 > --> Confirm html shows autocomplete off on the password field >6. Set 'PatronSelfRegistration' system preference to 'Allow' and PatronSelfRegistrationDefaultCategory to 'Board' >7. Visit http://master/cgi-bin/koha/opac-memberentry.pl >9. Repeat step 3 > --> Confirm html shows autocomplete off on the password field >10. Connect to the OPAC >11. Click on Change password >11. Repeat step 3 > --> Confirm html shows autocomplete off on the password field >12. Set 'EnableExpiredPasswordReset' system preference to 'Enable' >13. Visit http://master/cgi-bin/koha/opac-reset-password.pl >14. Repeat step 3 > --> Confirm html shows autocomplete off on the password field >--- > .../opac-tmpl/bootstrap/en/includes/overdrive-login.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- > .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 6 +++--- > .../bootstrap/en/modules/opac-password-recovery.tt | 4 ++-- > .../en/modules/opac-registration-confirmation.tt | 8 ++++---- > .../opac-tmpl/bootstrap/en/modules/opac-reset-password.tt | 2 +- > 7 files changed, 15 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc >index cf3ea1912d..10e862d41f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc >@@ -11,7 +11,7 @@ > <div class="modal-body"> > <fieldset class="brief"> > <label for="ODpassword">Password:</label> >- <input type="password" name="ODpassword" id="ODpassword" value="" /> >+ <input type="password" name="ODpassword" id="ODpassword" value="" autocomplete="off" /> > </fieldset> > </div> > <div class="modal-footer"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index c7029fcd19..3e95981a36 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -224,11 +224,11 @@ > [% END %] > <div class="form-group"> > <label for="userid">Login:</label> >- <input class="form-control" type="text" size="25" id="userid" name="userid" /> >+ <input class="form-control" type="text" size="25" id="userid" name="userid" autocomplete="off" /> > </div> > <div class="form-group"> > <label for="password">Password:</label> >- <input class="form-control" type="password" size="25" id="password" name="password" /> >+ <input class="form-control" type="password" size="25" id="password" name="password" autocomplete="off" /> > </div> > <fieldset class="action"> > <input type="submit" value="Log in" class="btn btn-primary" /> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 5bd55356a0..c9fc80d36d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -902,11 +902,11 @@ > > <ol> > <li><label for="password" class="[% required.password | html %]">Password:</label> >- <input type="password" name="borrower_password" id="password" class="[% required.password | html %]" /> >+ <input type="password" name="borrower_password" id="password" class="[% required.password | html %]" autocomplete="off" /> > <div class="required_label [% required.password | html %]">Required</div> > </li> > <li><label for="password2" class="[% required.password | html %]">Confirm password:</label> >- <input type="password" name="borrower_password2" id="password2" /> >+ <input type="password" name="borrower_password2" id="password2" autocomplete="off" /> > <div class="required_label [% required.password | html %]">Required</div> > </li> > </ol> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt >index 54f5b35025..5b0ab95dd5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt >@@ -74,15 +74,15 @@ > [% END %] > <div class="form-group"> > <label for="Oldkey">Current password:</label> >- <input class="form-control focus" type="password" id="Oldkey" size="25" name="Oldkey" /> >+ <input class="form-control focus" type="password" id="Oldkey" size="25" name="Oldkey" autocomplete="off" /> > </div> > <div class="form-group"> > <label for="Newkey">New password:</label> >- <input class="form-control" type="password" id="Newkey" size="25" name="Newkey" /> >+ <input class="form-control" type="password" id="Newkey" size="25" name="Newkey" autocomplete="off" /> > </div> > <div class="form-group"> > <label for="Confirm">Re-type new password:</label> >- <input class="form-control" type="password" id="Confirm" size="25" name="Confirm" /> >+ <input class="form-control" type="password" id="Confirm" size="25" name="Confirm" autocomplete="off" /> > </div> > </fieldset> > <fieldset class="action"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >index 78a7d9f5ef..8d3ff120a3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >@@ -152,12 +152,12 @@ > [% END %] > <div class="form-group"> > <label for="newPassword">New password:</label> >- <input class="form-control" type="password" id="newPassword" size="40" name="newPassword" /> >+ <input class="form-control" type="password" id="newPassword" size="40" name="newPassword" autocomplete="off" /> > </div> > > <div class="form-group"> > <label for="repeatPassword">Confirm new password:</label> >- <input class="form-control" type="password" id="repeatPassword" size="40" name="repeatPassword" /> >+ <input class="form-control" type="password" id="repeatPassword" size="40" name="repeatPassword" autocomplete="off" /> > </div> > > <fieldset class="action"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >index 3c7baae16a..dc5e3a7388 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >@@ -88,15 +88,15 @@ > <legend>Log in to your account:</legend> > <label for="userid">Login:</label> > [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] >- <input class="form-control" type="text" id="userid" size="10" name="userid" value="[% borrower.userid | html %]" /> >+ <input class="form-control" type="text" id="userid" size="10" name="userid" value="[% borrower.userid | html %]" autocomplete="off" /> > [% ELSE %] >- <input class="form-control" type="text" id="userid" size="10" name="userid" value="" /> >+ <input class="form-control" type="text" id="userid" size="10" name="userid" value="" autocomplete="off" /> > [% END %] > <label for="password">Password:</label> > [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] >- <input class="form-control" type="password" id="password" size="10" name="password" value="[% password_cleartext | html %]" /> >+ <input class="form-control" type="password" id="password" size="10" name="password" value="[% password_cleartext | html %]" autocomplete="off" /> > [% ELSE %] >- <input class="form-control" type="password" id="password" size="10" name="password" value="" /> >+ <input class="form-control" type="password" id="password" size="10" name="password" value="" autocomplete="off" /> > [% END %] > <fieldset class="action"> > <input type="submit" value="Log in" class="btn btn-primary" /> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt >index ac9289310f..4aa2070b46 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt >@@ -80,7 +80,7 @@ > <fieldset class="brief"> > <div class="form-group"> > <label for="userid">Login:</label> >- <input class="form-control" type="text" size="25" id="userid" name="userid" /> >+ <input class="form-control" autocomplete="off" type="text" size="25" id="userid" name="userid" /> > </div> > <div class="form-group"> > <label for="currentpassword">Current password:</label> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33343
:
149107
|
151532
|
151533
|
151544
|
151545
|
152066
|
152067