Attachment 149143 Details for Bug 32412 – Bug 32412: Empty coce container before appending image

[patch] Bug 32412: Empty coce container before appending image

Bug-32412-Empty-coce-container-before-appending-im.patch (text/plain), 1.28 KB, created by Lucas Gass (lukeg) on 2023-04-04 21:54:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-04-04 21:54:03 UTC

Size: 1.28 KB

patch

obsolete

>From efe9e2e3d13bedf768ce917a51120b70b032f8cb Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 4 Apr 2023 21:50:39 +0000
>Subject: [PATCH] Bug 32412: Empty coce container before appending image
>
>To test:
>1. Apply patch and clear browser cache
>2. Turn on Coce for the OPAC.
>3. OPACShelfBrowser must be on
>4. Find a record that returns a cover image and open it's detail page.
>5. Use the next/previous navigation links in the OPACShelfBrowser
>6. Notice that no extra image is being added to the biblio-cover-slider.
>7. Make sure that Coce images still load correctly in on the OPAC detail page, OPAC results page, and in the shelf browser.
>---
> koha-tmpl/opac-tmpl/bootstrap/js/coce.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/coce.js b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
>index c8829aeb98..65772380dd 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
>@@ -40,7 +40,7 @@ KOHA.coce = {
>                             }
>                         };
>                         $(this).attr('href', url);
>-                        $(this).append(img);
>+                        $(this).empty().append(img);
>                     });
>                 }
>             },
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32412: 149143 | 149219 | 150567 | 150620 | 150625 | 150626