Bugzilla – Attachment 149149 Details for
Bug 27513
Add description to reports page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27513: Add notes to variables for report parameters template
Bug-27513-Add-notes-to-variables-for-report-parame.patch (text/plain), 1.69 KB, created by
Lucas Gass (lukeg)
on 2023-04-04 22:50:24 UTC
(
hide
)
Description:
Bug 27513: Add notes to variables for report parameters template
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-04-04 22:50:24 UTC
Size:
1.69 KB
patch
obsolete
>From 7c8ca35c30c2a1749046b63c8f5160b8e60bd839 Mon Sep 17 00:00:00 2001 >From: Philip Orr <philip.orr@lmscloud.de> >Date: Fri, 31 Mar 2023 07:12:48 +0000 >Subject: [PATCH] Bug 27513: Add notes to variables for report parameters > template > >This patch adds the TT variable 'notes' to the variables >that guided_reports.pl passes to the template guided_reports_start.tt >during SQL parameters entry in the phase 'Run this report'. > >To test: >1. apply the patch >2. navigate to Reports -> Guided Reports -> Create from SQL >3. create an SQL report that includes at least one parameter, e.g.: > SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> > the actual SQL and name of the report doesn't matter much, just make > sure that you also put a note e.g. "Test text for display" in the > field "Notes:" before you save the report. >4. run the report >5. the note you entered should now be displayed below the heading > "Enter parameters for report..." > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > reports/guided_reports.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index f4ed6cfdfc..94cff9fe21 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -824,6 +824,7 @@ elsif ($phase eq 'Run this report'){ > } > $template->param('sql' => $sql, > 'name' => $name, >+ 'notes' => $notes, > 'sql_params' => \@tmpl_parameters, > 'auth_val_errors' => \@authval_errors, > 'enter_params' => 1, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27513
:
149012
|
149068
| 149149