Attachment 149190 Details for Bug 33381 – Bug 33381: Fix sidemenu active and hover styling

[patch] Bug 33381: Fix sidemenu active and hover styling

Bug-33381-Fix-sidemenu-active-and-hover-styling.patch (text/plain), 2.03 KB, created by Pedro Amorim on 2023-04-05 09:10:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2023-04-05 09:10:56 UTC

Size: 2.03 KB

patch

obsolete

>From 4c7c8d49888da9eb5ad18a8180f9ccb20b313d2b Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Sat, 1 Apr 2023 17:38:33 +0000
>Subject: [PATCH] Bug 33381: Fix sidemenu active and hover styling
>
>Change router link active class match rule. This makes it so that the route erm/agreements/1 will also match the router-link /erm/agreements instead of the previous exact match rule, thus adding the 'current' class
>Update styling router-links to not apply 'current' styling when
>.disabled
>---
> .../prog/js/vue/components/ERM/Main.vue              | 12 +++++-------
> koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts   |  2 +-
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue
>index ae4b5b56a58..26e73eaf20d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue
>@@ -215,9 +215,6 @@ export default {
> </script>
> 
> <style>
>-#navmenulist a.router-link-active {
>-    font-weight: 700;
>-}
> #menu ul ul,
> #navmenulist ul ul {
>     padding-left: 2em;
>@@ -241,13 +238,14 @@ textarea {
> .flatpickr-input {
>     width: 30%;
> }
>-
>+#navmenulist ul li a.current.disabled {
>+    background-color: inherit;
>+    border-left: 5px solid #e6e6e6;
>+    color: #000;
>+}
> #navmenulist ul li a.disabled {
>     color: #666;
>     pointer-events: none;
>     font-weight: 700;
> }
>-#navmenulist ul li a.disabled.router-link-active {
>-    color: #000;
>-}
> </style>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts
>index e4290931dfd..a7eaa1413f5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts
>@@ -21,7 +21,7 @@ import { routes } from "../routes/erm";
> 
> const router = createRouter({
>     history: createWebHistory(),
>-    linkExactActiveClass: "current",
>+    linkActiveClass: "current",
>     routes,
> });
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33381: 149022 | 149061 | 149063 | 149188 | 149189 | 149190 | 149225