Bugzilla – Attachment 149208 Details for
Bug 33408
Fetch sysprefs from svc/config/systempreferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33408: Remove obsolete tests and template sys pref code
Bug-33408-Remove-obsolete-tests-and-template-sys-p.patch (text/plain), 3.25 KB, created by
Pedro Amorim
on 2023-04-05 13:04:24 UTC
(
hide
)
Description:
Bug 33408: Remove obsolete tests and template sys pref code
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-04-05 13:04:24 UTC
Size:
3.25 KB
patch
obsolete
>From 366b525bb11339148cf84b227b105e37a0834f18 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 5 Apr 2023 11:43:52 +0000 >Subject: [PATCH] Bug 33408: Remove obsolete tests and template sys pref code > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/erm/erm.tt | 5 --- > t/cypress/support/commands.js | 31 ------------------- > 2 files changed, 36 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt >index e356e85dd87..98c0a4294b6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt >@@ -33,13 +33,8 @@ > const eholdings_packages_table_settings = [% TablesSettings.GetTableSettings( 'erm', 'eholdings', 'packages', 'json' ) | $raw %]; > const eholdings_titles_table_settings = [% TablesSettings.GetTableSettings( 'erm', 'eholdings', 'titles', 'json' ) | $raw %]; > >- const ERMProviders = "[% Koha.Preference('ERMProviders') | html %]"; >- const erm_providers = ERMProviders.split(','); >- > const max_allowed_packet = [% To.json(max_allowed_packet) | $raw %]; > >- const ERMModule = [% IF Koha.Preference('ERMModule') %]true[% ELSE %]false[% END %]; >- > const logged_in_user_lists = [% To.json(logged_in_user.virtualshelves.unblessed) | $raw %]; > > const logged_in_user = [% To.json(logged_in_user.unblessed) | $raw %]; >diff --git a/t/cypress/support/commands.js b/t/cypress/support/commands.js >index bea38fb7c9e..60bea1fcb6c 100644 >--- a/t/cypress/support/commands.js >+++ b/t/cypress/support/commands.js >@@ -39,34 +39,3 @@ Cypress.Commands.add('login', (username, password) => { > cy.get("#password").type(pass) > cy.get("#submit-button").click() > }) >- >-Cypress.Commands.add('set_ERM_sys_pref_value', (enable) => { >- cy.visit('/cgi-bin/koha/admin/admin-home.pl') >- cy.get("h4").contains("Global system preferences").click(); >- cy.get("a[title^=E-resource]").contains("E-resource management").click(); >- cy.get('#pref_ERMModule').then(($select) => { >- // Only enable if currently disabled, or only disable if currently enabled >- let sys_pref_value = $select.find(":selected").text().trim(); >- if (enable && sys_pref_value == 'Disable' || !enable && sys_pref_value == 'Enable') { >- cy.get("#pref_ERMModule").select(enable ? 'Enable' : 'Disable'); >- cy.get(".save-all").first().click(); >- Cypress.env("current_ERM_Module_sys_pref_value", enable); >- cy.wait(500); // Cypress is too fast! >- } >- }) >-}) >- >-Cypress.Commands.add('fetch_initial_ERM_sys_pref_value', () => { >- cy.login(); >- cy.visit('/cgi-bin/koha/admin/admin-home.pl') >- cy.get("h4").contains("Global system preferences").click(); >- cy.get("a[title^=E-resource]").contains("E-resource management").click(); >- cy.get('#pref_ERMModule').then(($select) => { >- Cypress.env('initial_ERM_Module_sys_pref_value', $select.find(":selected").text().trim() == 'Enable'); >- }) >-}) >- >-Cypress.Commands.add('reset_initial_ERM_sys_pref_value', () => { >- cy.login(); >- cy.set_ERM_sys_pref_value(Cypress.env("initial_ERM_Module_sys_pref_value")); >-}) >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33408
:
149131
|
149132
|
149133
|
149134
|
149184
|
149185
|
149186
|
149196
|
149197
|
149198
|
149200
|
149204
|
149205
|
149206
|
149207
|
149208
|
149209
|
149254
|
149438
|
149516
|
149517
|
149518
|
149535
|
149536
|
149537
|
149538
|
149539
|
149540
|
149541
|
149542
|
149543
|
149570