Bugzilla – Attachment 149223 Details for
Bug 32357
Set borrower_message_preferences.days_in_advance default to NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL
Bug-32357-Set-borrowermessagepreferencesdaysinadva.patch (text/plain), 2.12 KB, created by
David Nind
on 2023-04-05 20:55:09 UTC
(
hide
)
Description:
Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-05 20:55:09 UTC
Size:
2.12 KB
patch
obsolete
>From bba459da9529cdb037343464582ee604895d851a Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Mon, 28 Nov 2022 22:01:37 +0000 >Subject: [PATCH] Bug 32357: Set borrower_message_preferences.days_in_advance > default to NULL > >To test: >1. prove t/db_dependent/cronjobs/advance_notices_digest.t >2. prove t/db_dependent/Letters/TemplateToolkit.t >3. prove t/db_dependent/Koha/CurbsidePickups.t >4. prove t/db_dependent/Koha/Patrons.t >5. prove t/db_dependent/Patron/Messaging.t > >Signed-off-by: David Nind <david@davidnind.com> >--- > installer/data/mysql/atomicupdate/bug_32357.pl | 14 ++++++++++++++ > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 15 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_32357.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_32357.pl b/installer/data/mysql/atomicupdate/bug_32357.pl >new file mode 100644 >index 0000000000..6e4b8b57e3 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_32357.pl >@@ -0,0 +1,14 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "32357", >+ description => "Set borrower_message_preferences.days_in_advance default to NULL", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ $dbh->do(q{ >+ ALTER TABLE borrower_message_preferences ALTER days_in_advance SET DEFAULT NULL; >+ }); >+ say $out "Updated column 'borrower_message_preferences.days_in_advance default' to NULL"; >+ }, >+}; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 52e8ad2c5d..bba9eaa16f 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1237,7 +1237,7 @@ CREATE TABLE `borrower_message_preferences` ( > `borrowernumber` int(11) DEFAULT NULL, > `categorycode` varchar(10) DEFAULT NULL, > `message_attribute_id` int(11) DEFAULT 0, >- `days_in_advance` int(11) DEFAULT 0, >+ `days_in_advance` int(11) DEFAULT NULL, > `wants_digest` tinyint(1) NOT NULL DEFAULT 0, > PRIMARY KEY (`borrower_message_preference_id`), > KEY `borrowernumber` (`borrowernumber`), >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32357
:
144307
|
144309
|
146475
|
149223
|
150405