Bugzilla – Attachment 149288 Details for
Bug 33429
Use template wrapper for breadcrumbs: Plugins
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33429: Use template wrapper for breadcrumbs: Plugins
Bug-33429-Use-template-wrapper-for-breadcrumbs-Plu.patch (text/plain), 5.33 KB, created by
David Nind
on 2023-04-07 18:48:39 UTC
(
hide
)
Description:
Bug 33429: Use template wrapper for breadcrumbs: Plugins
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-07 18:48:39 UTC
Size:
5.33 KB
patch
obsolete
>From 8f09aef9700dc1c6aec94ab4cb1581e5b353abf5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 6 Apr 2023 10:40:48 +0000 >Subject: [PATCH] Bug 33429: Use template wrapper for breadcrumbs: Plugins > >This patch updates plugin management templates so that they use the new >WRAPPER for displaying breadcrumbs. > >To test, apply the patch and test each page and its variations. >Breadcrumbs should look correct, and each link should be correct. > >- In koha-conf.xml, look for "enable_plugins" > - If this is set to 0, plugins are disabled: > <enable_plugins>0</enable_plugins> > - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which > should say "Plugins disabled." Check the breadcrumbs on this page. > - Enable plugins by changing the settimg in koha-conf.xml to 1 (a > restart of services is required): <enable_plugins>1</enable_plugins> > - Go to Administration -> Manage plugins > - Test this page and the "Upload plugin" page. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../en/modules/plugins/plugins-disabled.tt | 28 ++++++++----------- > .../prog/en/modules/plugins/plugins-home.tt | 23 ++++++--------- > .../prog/en/modules/plugins/plugins-upload.tt | 28 ++++++++----------- > 3 files changed, 30 insertions(+), 49 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-disabled.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-disabled.tt >index 1b8c7c6911..c94a38348c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-disabled.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-disabled.tt >@@ -1,3 +1,4 @@ >+[% USE raw %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Upload plugin › Plugins › Tools › Koha</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -9,23 +10,16 @@ > [% INCLUDE 'circ-search.inc' %] > [% END %] > >-[% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >- <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> >- </li> >- <li> >- <a href="#" aria-current="page"> >- Plugins disabled >- </a> >- </li> >- </ol> >-</nav> >-[% END %] >+ [% WRAPPER 'sub-header.inc' %] >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] >+ <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> >+ [% END %] >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Plugins disabled</span> >+ [% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+ [% END #/ WRAPPER sub-header.inc %] > > <div class="container-fluid"> > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >index 775c3f0bba..0ee44d36b8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >@@ -13,22 +13,15 @@ > [% END %] > > [% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> >- </li> >- <li> >- <a href="#" aria-current="page"> >- Plugins >- </a> >- </li> >- </ol> >-</nav> >-[% END %] >+ [% END %] >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Plugins</span> >+ [% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+[% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt >index 08f08d192b..96e74dc7f6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt >@@ -1,3 +1,4 @@ >+[% USE raw %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Upload plugin › Plugins › Tools › Koha </title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -9,23 +10,16 @@ > [% INCLUDE 'circ-search.inc' %] > [% END %] > >-[% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >- <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> >- </li> >- <li> >- <a href="#" aria-current="page"> >- Upload plugins >- </a> >- </li> >- </ol> >-</nav> >-[% END %] >+ [% WRAPPER 'sub-header.inc' %] >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] >+ <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> >+ [% END %] >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <wrap>Upload plugins</wrap> >+ [% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+ [% END #/ WRAPPER sub-header.inc %] > > <div class="container-fluid"> > <div class="row"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33429
:
149230
|
149288
|
149301