Attachment 149350 Details for Bug 32956 – Bug 32956: Use template wrapper for HTML customizations tabs

[patch] Bug 32956: Use template wrapper for HTML customizations tabs

Bug-32956-Use-template-wrapper-for-HTML-customizat.patch (text/plain), 3.63 KB, created by Katrin Fischer on 2023-04-09 11:25:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-04-09 11:25:53 UTC

Size: 3.63 KB

patch

obsolete

>From 7496af3e6adffc5e643b971c63f861a54cfe72d2 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 8 Feb 2023 17:46:48 +0000
>Subject: [PATCH] Bug 32956: Use template wrapper for HTML customizations tabs
>
>This patch updates the HTML customizations template to replace tab
>markup with the use of WRAPPERs.
>
>- Apply the patch and go to Tools -> HTML customizations.
>- Create or edit an entry.
>- You should see tabs for each available language, for example
>  Default, English, French.
>- Test adding content to each language to confirm that the correct
>  information is saved under the correct tab.
>
>Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../en/modules/tools/additional-contents.tt   | 25 ++++++++++---------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>index f4a2736f28..8545297b88 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>@@ -270,19 +270,20 @@
>         </fieldset>
> 
>         [% IF languages.size %]
>-            <div id="tabs" class="toptabs">
>-                <ul class="nav nav-tabs" role="tablist">
>+            [% WRAPPER tabs id= "tabs" %]
>+                [% WRAPPER tabs_nav %]
>                     [% FOR language IN languages %]
>                         [% IF language.lang == 'default' %]
>-                            <li role="presentation"><a href="#lang_default" aria-controls="lang_default" role="tab" data-toggle="tab">Default</a></li>
>+                            [% WRAPPER tab_item tabname= "lang_default" %] <span>Default</span> [% END %]
>                         [% ELSE %]
>-                            <li role="presentation"><a href="#lang_[% language.lang | uri %]" aria-controls="lang_[% language.lang | uri %]" role="tab" data-toggle="tab">[% language.description | html %]</a></li>
>+                            [% WRAPPER tab_item tabname= "lang_${language.lang}" %] [% language.description | html %] [% END %]
>                         [% END %]
>                     [% END %]
>-                </ul>
>-                <div class="tab-content">
>+                [% END # /WRAPPER tabs_nav %]
>+
>+                [% WRAPPER tab_panels %]
>                     [% FOR language IN languages %]
>-                        <div id="lang_[% language.lang | uri %]" class="lang clearfix tab-pane" data-lang="[% language.description | html %]">
>+                        [% WRAPPER tab_panel tabname="lang_${language.lang}" %]
>                             <fieldset>
>                                 <ol>
>                                     <li>
>@@ -296,17 +297,17 @@
>                                     </li>
>                                 </ol>
>                             </fieldset>
>-                        </div>
>-                    [% END %]
>-                </div> 
>-            </div>
>+                        [% END # /WRAPPER tab_panel#lang %]
>+                    [% END # /FOR language %]
>+                [% END # /WRAPPER tab_panels %]
>+            [% END # /WRAPPER tabs %]
>         [% ELSE %]
>             <div id="lang_default">
>                 <div class="clearfix">
>                     <textarea name="content" id="content_default" data-lang="[% language.lang | html %]"  cols="75" rows="10">[% additional_content.content | html %]</textarea>
>                 </div>
>             </div>
>-        [% END %]
>+        [% END # /IF languages.size %]
>     </form>
> [% END %]
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32956: 146597 | 147822 | 148795 | 149350