Attachment 149364 Details for Bug 32127 – Bug 32127: Sort by description in Koha::Template::Plugin::Categories

[patch] Bug 32127: Sort by description in Koha::Template::Plugin::Categories

Bug-32127-Sort-by-description-in-KohaTemplatePlugi.patch (text/plain), 1.74 KB, created by Katrin Fischer on 2023-04-09 12:24:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-04-09 12:24:27 UTC

Size: 1.74 KB

patch

obsolete

>From 95afd8337bd37855c1cd426cefff96a75a0c6849 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 7 Nov 2022 11:42:49 -1000
>Subject: [PATCH] Bug 32127: Sort by description in
> Koha::Template::Plugin::Categories
>
>Like in Koha::Template::Plugin::Branches, methods in
>Koha::Template::Plugin::Categories must return categories sorted by
>description.
>
>Test plan :
>1) Create a new patron category with code ZZZ and description AAAAAA
>2) Go to patron search /cgi-bin/koha/members/members-home.pl
>3) Look at filter by category :
>=> Without patch the value AAAAAA is last
>=> With patch the value AAAAAA is first
>4) Click on 'New patron'
>=> Without patch the value AAAAAA is last
>=> With patch the value AAAAAA is first
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> Koha/Template/Plugin/Categories.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Template/Plugin/Categories.pm b/Koha/Template/Plugin/Categories.pm
>index 4da8748ac4..4d425d6f9e 100644
>--- a/Koha/Template/Plugin/Categories.pm
>+++ b/Koha/Template/Plugin/Categories.pm
>@@ -25,12 +25,12 @@ use Koha::Patron::Categories;
> 
> sub all {
>     my ( $self, $params ) = @_;
>-    return Koha::Patron::Categories->search($params);
>+    return Koha::Patron::Categories->search($params, { order_by => [ 'description' ] } );
> }
> 
> sub limited {
>     my ( $self, $params ) = @_;
>-    return Koha::Patron::Categories->search_with_library_limits($params);
>+    return Koha::Patron::Categories->search_with_library_limits($params, { order_by => [ 'description' ] } );
> }
> 
> sub GetName {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32127: 143382 | 143391 | 143815 | 148890 | 148891 | 148892 | 149099 | 149100 | 149364 | 149365