Bugzilla – Attachment 149384 Details for
Bug 33192
We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33192: (QA follow-up) Fix it-IT sample data and unit tests
Bug-33192-QA-follow-up-Fix-it-IT-sample-data-and-u.patch (text/plain), 2.96 KB, created by
Katrin Fischer
on 2023-04-10 14:44:03 UTC
(
hide
)
Description:
Bug 33192: (QA follow-up) Fix it-IT sample data and unit tests
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-10 14:44:03 UTC
Size:
2.96 KB
patch
obsolete
>From 90038b494979ca4509299310bfecf970b3b24740 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 10 Apr 2023 14:40:56 +0000 >Subject: [PATCH] Bug 33192: (QA follow-up) Fix it-IT sample data and unit > tests > >To test: >* prove t/db_dependent/Message.t >* Run the it-IT web installer and make sure 'email' is set. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > installer/data/mysql/localization/it-IT/custom.sql | 2 +- > t/db_dependent/Message.t | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/installer/data/mysql/localization/it-IT/custom.sql b/installer/data/mysql/localization/it-IT/custom.sql >index 2b856ac436..7fa65cfe54 100644 >--- a/installer/data/mysql/localization/it-IT/custom.sql >+++ b/installer/data/mysql/localization/it-IT/custom.sql >@@ -24,7 +24,7 @@ > UPDATE systempreferences SET value = 'cataloguing' WHERE variable = 'AcqCreateItem'; > UPDATE systempreferences SET value = '1' WHERE variable = 'AllowRenewalLimitOverride'; > UPDATE systempreferences SET value = 'annual' WHERE variable = 'autoBarcode'; >-UPDATE systempreferences SET value = 'email' WHERE variable = 'AutoEmailPrimaryAddress'; >+UPDATE systempreferences SET value = 'email' WHERE variable = 'EmailFieldPrimary'; > UPDATE systempreferences SET value = '1' WHERE variable = 'BiblioAddsAuthorities'; > UPDATE systempreferences SET value = 'surname|cardnumber' WHERE variable = 'BorrowerMandatoryField'; > UPDATE systempreferences SET value = '0' WHERE variable = 'BorrowersLog'; >diff --git a/t/db_dependent/Message.t b/t/db_dependent/Message.t >index b223c56505..95673c36c9 100755 >--- a/t/db_dependent/Message.t >+++ b/t/db_dependent/Message.t >@@ -50,11 +50,11 @@ my $letter = C4::Letters::GetPreparedLetter( > ); > > >-t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'OFF' ); >+t::lib::Mocks::mock_preference( 'EmailFieldPrimary', 'OFF' ); > C4::Message->enqueue($letter, $patron, 'email'); > my $message = C4::Message->find_last_message($patron->unblessed, 'TEST_MESSAGE', 'email'); > like( $message->{metadata}, qr{heÃllo} ); >-is ($message->{to_address}, $patron->email, "To address set correctly for AutoEmailPrimaryAddress 'off'"); >+is ($message->{to_address}, $patron->email, "To address set correctly for EmailFieldPrimary 'off'"); > > $letter = C4::Letters::GetPreparedLetter( > ( >@@ -69,7 +69,7 @@ $message->append($letter); > like( $message->{metadata}, qr{heÃllo} ); > like( $message->{metadata}, qr{hellâ¤ï¸} ); > >-t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'emailpro' ); >+t::lib::Mocks::mock_preference( 'EmailFieldPrimary', 'emailpro' ); > C4::Message->enqueue($letter, $patron, 'email'); > $message = C4::Message->find_last_message($patron->unblessed, 'TEST_MESSAGE', 'email'); >-is ($patron->notice_email_address, $patron->emailpro, "To address set correctly for AutoEmailPrimaryAddress 'emailpro'"); >+is ($patron->notice_email_address, $patron->emailpro, "To address set correctly for EmailFieldPrimary 'emailpro'"); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33192
:
148118
|
148119
|
148139
|
148140
|
149381
|
149382
|
149383
| 149384