Bugzilla – Attachment 149404 Details for
Bug 18829
Elasticsearch - Add ability to view the ES indexed record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18829: (QA follow-up) I18N, test character and breadcrumbs
Bug-18829-QA-follow-up-I18N-test-character-and-bre.patch (text/plain), 3.23 KB, created by
Katrin Fischer
on 2023-04-10 17:08:18 UTC
(
hide
)
Description:
Bug 18829: (QA follow-up) I18N, test character and breadcrumbs
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-10 17:08:18 UTC
Size:
3.23 KB
patch
obsolete
>From b82e459b27653e38975f8d95bca5156b6a740e60 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 10 Apr 2023 17:00:21 +0000 >Subject: [PATCH] Bug 18829: (QA follow-up) I18N, test character and > breadcrumbs > >* Removes a 'heart' character from the file, probably added for testing >* Corrects breadbrumbs to make QA test tool happy >* Makes JS message translatable (test by manipulating the link to an invalid record number in DOM) > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/showelastic.tt | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 9da3b22987..79b261ed4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -1749,7 +1749,7 @@ Note that permanent location is a code, and location may be an authval. > var pageElastic = $(this).attr("href"); > $("#elasticPreview .modal-body").load(pageElastic, function( response, status, xhr ) { > if( status == 'error' ){ >- $("#elasticPreview .modal-body").html('<h1>An error has occurred!</h1><h2><em>Error 404</em></h2><li>An internal link in the client is broken and the page does not exist</li></ul><h3>What\'s next?</h3><ul style="margin-bottom: 1em; padding-bottom: 1em; border-bottom: 1px solid #CCC;"><li>Use top menu bar to navigate to another part of Koha.</li><li>To report a broken link or any other issue, please contact the Koha administrator. <a href="mailto:[% Koha.Preference('KohaAdminEmailAddress') | uri %]">Send email</a></li></ul>'); >+ $("#elasticPreview .modal-body").html("<h1>"+_("An error has occurred!")+"</h1><h2><em>"+_("Error 404")+"</em></h2><ul><li>"+_("An internal link in the staff interface is broken and the page does not exist")+"</li></ul><h3>"+_("What's next?")+"</h3><ul style='margin-bottom: 1em; padding-bottom: 1em; border-bottom: 1px solid #CCC;'><li>"+_("Use top menu bar to navigate to another part of Koha.")+"</li><li>"+_("To report a broken link or any other issue, please contact the Koha administrator.")+" <a href='mailto:[% Koha.Preference("KohaAdminEmailAddress") | uri %]'>"+_("Send email")+"</a></li></ul>"); > } > }); > $('#elasticPreview').modal({show:true}); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt >index 85cde0b247..c90e6d6e3b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt >@@ -1,6 +1,6 @@ >-â¤[% INCLUDE 'doc-head-open.inc' %] >+[% INCLUDE 'doc-head-open.inc' %] > [% USE raw %] >-<title>Koha › Catalog › Elasticsearch record</title> >+<title>Elasticsearch record › Catalog › Koha</title> > <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> > </head> > <body id="catalog_showelastic" class="catalog"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18829
:
64456
|
89001
|
89007
|
89248
|
89249
|
89250
|
90370
|
108103
|
108104
|
108191
|
108944
|
108945
|
148757
|
148758
|
148759
|
148760
|
149400
|
149401
|
149402
|
149403
| 149404 |
149745