Bugzilla – Attachment 149472 Details for
Bug 33483
Cannot link EBSCO's package with local agreement
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33483: Restore 'select'
Bug-33483-Restore-select.patch (text/plain), 2.66 KB, created by
Jonathan Druart
on 2023-04-11 19:16:12 UTC
(
hide
)
Description:
Bug 33483: Restore 'select'
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-04-11 19:16:12 UTC
Size:
2.66 KB
patch
obsolete
>From 29c6d8318d8ab730704a895008fea74546dc5336 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 11 Apr 2023 21:14:25 +0200 >Subject: [PATCH] Bug 33483: Restore 'select' > >We are not supposed to see edit and delete buttons, but select instead, >to pick an agreement. > >Regression introduced by > commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 > Bug 33066: Remove build_datatable > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../js/vue/components/ERM/AgreementsList.vue | 20 ++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 18a38af1eb4..9be9e8a6b69 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -39,6 +39,7 @@ > @show="doShow" > @edit="doEdit" > @delete="doDelete" >+ @select="doSelect" > ></KohaTable> > </div> > <div v-else class="dialog message"> >@@ -127,7 +128,16 @@ export default { > }, > actions: { > 0: ["show"], >- "-1": ["edit", "delete"], >+ "-1": this.embedded >+ ? [ >+ { >+ select: { >+ text: this.$__("Select"), >+ icon: "fa fa-check", >+ }, >+ }, >+ ] >+ : ["edit", "delete"], > }, > default_filters: { > "user_roles.user_id": function () { >@@ -192,6 +202,10 @@ export default { > } > ) > }, >+ doSelect: function (agreement, dt, event) { >+ this.$emit("select-agreement", agreement.agreement_id) >+ this.$emit("close") >+ }, > table_url: function () { > let url = "/api/v1/erm/agreements" > if (this.filters.by_expired) >@@ -199,10 +213,6 @@ export default { > "?max_expiration_date=" + this.filters.max_expiration_date > return url > }, >- select_agreement: function (agreement_id) { >- this.$emit("select-agreement", agreement_id) >- this.$emit("close") >- }, > filter_table: async function () { > if (!embedded) { > let new_route = build_url( >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33483
:
149437
|
149452
|
149455
|
149456
|
149470
|
149471
|
149472
|
149473
|
149527
|
149528
|
149529
|
149555
|
149564
|
149565
|
149566
|
149567
|
149568
|
149569
|
149847
|
149848
|
149849
|
149850
|
149851
|
149852